- Notifications
You must be signed in to change notification settings - Fork928
fix: Remove audit warning if unlicensed#4387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
if you're triple sure this doesn't give every unlicensed deployment audit logging for free then LGTM 👍
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Makes sense, it wasn't clear to me in the code that audit logging was on by default.
@f0ssel we should probably have better testing around these warnings anyways, since it's a big no-no to display any if unlicensed (and maybe we should just change the code to do that). |
Fixes#4383.