Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: tokens#4380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
f0ssel merged 17 commits intomainfromf0ssel/machine-keys
Oct 6, 2022
Merged

feat: tokens#4380

f0ssel merged 17 commits intomainfromf0ssel/machine-keys
Oct 6, 2022

Conversation

f0ssel
Copy link
Contributor

@f0sself0ssel commentedOct 5, 2022•
edited
Loading

Closes#3692

bpmct and ntimo reacted with hooray emojintimo reacted with heart emoji
@f0sself0ssel marked this pull request as ready for reviewOctober 5, 2022 20:59
@f0sself0ssel requested a review froma team as acode ownerOctober 5, 2022 20:59
@f0sself0ssel requested review fromKira-Pilot andEmyrk and removed request fora teamOctober 5, 2022 20:59
@f0sself0ssel marked this pull request as draftOctober 6, 2022 14:38
@f0sself0ssel marked this pull request as ready for reviewOctober 6, 2022 17:01
@f0sself0ssel requested review frombpmct anda team and removed request forEmyrkOctober 6, 2022 17:01
Copy link
Member

@bpmctbpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Are "machine key" and "personal access token" interchangeable?

I prefer PAT / "token", but don't have strong feelings either way, especially if the behaviors are the same. The main rationale is I haven't seen "machine key" used commonly in software like this, but 🤷🏼

@coadler
Copy link
Contributor

I find "machine key" a bit confusing as we have machine keys in Tailscale as well.

f0ssel reacted with thumbs up emojif0ssel reacted with heart emoji

@f0ssel
Copy link
ContributorAuthor

machine key is programmer codename 100% - it's because the data model is an api key with the login type "machine". I can change this to whatever makes the most sense for product.

In v1 we usedcoder tokens and also call the api key flag in the CLI for v2--token. Can we call it justcoder tokens again? PAT doesn't really mean anything to me personally.

@f0sself0ssel requested a review frombpmctOctober 6, 2022 18:32
@f0sself0ssel changed the titlefeat: machine keysfeat: tokensOct 6, 2022
@bpmct
Copy link
Member

Tokens makes sense to me!

@f0sself0ssel requested a review fromkylecarbsOctober 6, 2022 18:41
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks fine but you still say "machine token" in a lot of places. Also, using both "api key" and "token" and "key" and "session token" for the same thing is confusing and we should just stick to one where possible IMO

@f0sself0sselenabled auto-merge (squash)October 6, 2022 18:57
@f0sself0ssel merged commitf5df548 intomainOct 6, 2022
@f0sself0ssel deleted the f0ssel/machine-keys branchOctober 6, 2022 19:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@Kira-PilotKira-PilotAwaiting requested review from Kira-PilotKira-Pilot was automatically assigned from coder/ts

@bpmctbpmctAwaiting requested review from bpmct

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create long-lived tokens for CI/CD/automation (or tokens for a specific duration)
5 participants
@f0ssel@coadler@bpmct@kylecarbs@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp