owner (default) which means only the owner can access it, basically means "unshared"
authenticated means any user that is signed in
public means any user, including unauthenticated users (also bypasses scope checks on API keys intentionally)

TODO:

Addsharing_level to provider code
Big tests
Test for scope
Addshare to the provider itself
Add to example templates for discovery
Add method for creating a new API key with a given scope (which I needed for writing tests)
~~Add flag to control available levels for enterprise customers only~~ (future PR)

deansheather added6 commits

October 5, 2022 19:01

feat: app sharing pt.1

6b68642

Merge branch 'main' into dean/app-sharing

1ca5c46

feat: app sharing pt.2

67a7057

feat: app sharing pt.3

d7403ec

Merge branch 'main' into dean/app-sharing

2a5bcc8

feat: app sharing pt.4

a2eacaa

bpmct mentioned this pull request

Oct 6, 2022

Opening the link generated by the port forward button requires authentication#4358

Closed

deansheather added2 commits

October 12, 2022 16:46

chore: move app sharing to open source

e4f6fd6

Merge branch 'main' into dean/app-sharing

40300a7

deansheather changed the title~~feat: app sharing (enterprise)~~feat: app sharing (now open source!)

Oct 12, 2022

deansheather added3 commits

October 12, 2022 17:24

fixup! Merge branch 'main' into dean/app-sharing

89a75d0

chore: add test for app sharing with scoped keys

4f6aac8

chore: add share to all example templates

9f45850

deansheather marked this pull request as ready for review

October 12, 2022 20:03

deansheather requested a review froma team as acode owner

October 12, 2022 20:03

deansheather requested review frompresleyp,f0ssel,Emyrk,sreya anda team and removed request fora team

October 12, 2022 20:03

fixup! chore: add share to all example templates

cedc57d

presleyp approved these changes

Oct 12, 2022

View reviewed changes

Copy link

Contributor

presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Frontend ✅ looks cool!

sreya reviewed

Oct 12, 2022

View reviewed changes

Copy link

Collaborator

sreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The code seems pretty good overall. My one comment on the structure is there seems to be a lot of the "guts" of workspace apps spilling out intocoderd. Do you think any of this makes sense to break out into anapps package and concentrate a lot of the logic here?

coderd/database/migrations/000059_app_sharing_level.up.sql OutdatedShow resolvedHide resolved

coderd/database/queries/workspaceapps.sql OutdatedShow resolvedHide resolved

coderd/workspaceapps.go OutdatedShow resolvedHide resolved

coderd/database/migrations/000059_app_sharing_level.up.sql OutdatedShow resolvedHide resolved

coderd/workspaceapps.goShow resolvedHide resolved

Copy link

MemberAuthor

deansheather commentedOct 12, 2022

@sreya at the moment all of the applications code is in a single file so it's not spread out across coderd or anything like that. We will have to move this to a separate package to support satellites soon (Colin and I have plans), so since we already plan on moving it to it's own package and making a lot of changes I think we should leave it here for now to avoid having to do the same work twice (as we'll need to make a lot of other changes at the same time to support satellites).

Copy link

Collaborator

sreya commentedOct 12, 2022•
edited
Loading

@deansheather if you wish to do it in another PR i'm cool with that. Personally I think it's a little premature to start considering satellites but we can have that discussion elsewhere ❤️

Copy link

MemberAuthor

deansheather commentedOct 12, 2022•
edited
Loading

(our plans are to refactor all of the connection code so it doesn't depend directly on the database in upcoming weeks and move it all to a different package)