Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add experimental flag#4364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
f0ssel merged 5 commits intomainfromf0ssel/ff
Oct 4, 2022
Merged

feat: add experimental flag#4364

f0ssel merged 5 commits intomainfromf0ssel/ff
Oct 4, 2022

Conversation

f0ssel
Copy link
Contributor

No description provided.

@f0sself0ssel requested a review froma team as acode ownerOctober 4, 2022 19:16
@f0sself0ssel requested review fromKira-Pilot and removed request fora teamOctober 4, 2022 19:16
@f0sself0sselenabled auto-merge (squash)October 4, 2022 19:35
Copy link
Member

@Kira-PilotKira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Curious how we're planning on using this on the FE. Is this just for entitlements?

@f0sself0ssel merged commitffbaa93 intomainOct 4, 2022
@f0sself0ssel deleted the f0ssel/ff branchOctober 4, 2022 19:45
@f0ssel
Copy link
ContributorAuthor

@Kira-Pilot it's basically a global flag for the deployment, and since we were already fetch the license at the top level of the app I wanted to piggyback off entitlements to avoid another round trip. I avoided putting it inbuildinfo because that info comes from the binary and this experimental flag is set at runtime.

Kira-Pilot reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@Kira-PilotKira-PilotKira-Pilot approved these changes

@bpmctbpmctAwaiting requested review from bpmct

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@f0ssel@deansheather@Kira-Pilot

[8]ページ先頭

©2009-2025 Movatter.jp