- Notifications
You must be signed in to change notification settings - Fork928
chore: Deprecate old cookie value#4336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Older clis will need to be updated.Modern clis cannot communicate with <8.15 coderd
Emyrk commentedOct 3, 2022
Comment on lines -86 to -91
| // Delete this custom cookie set in November 2022. This is just to remain | ||
| // backwards compatible with older versions of Coder. | ||
| req.AddCookie(&http.Cookie{ | ||
| Name: "session_token", | ||
| Value: c.SessionToken, | ||
| }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Close enough to November. New clis cannot communicate with <8.15 coderds.
kylecarbs approved these changesOct 3, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Older clis will need to be updated.
Modern clis cannot communicate with <8.15 coderd
Future work
Remove logout legacy cookies:
coder/coderd/users.go
Lines 1021 to 1037 in0d1ab74
Enable CSRF:
coder/coderd/httpmw/csrf.go
Lines 35 to 39 in0d1ab74
Note
I began writing code to return nice errors
Coder cli version out of date to communicate with..., but the error code was messy.I think an easier way to do this is somehow write some generic code that says what version of
coderda cli can communicate with and vis-versa.It would be nice as a dev to say "Coder cli version 8.15+" is required for a coderd, so the cli can lookup the supported list. We can do this generically rather than a bunch of 1 off code in random spots accumulating debt.