Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add rich parameters#4311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
kylecarbs wants to merge18 commits intomainfromparameter
Closed

feat: add rich parameters#4311

kylecarbs wants to merge18 commits intomainfromparameter

Conversation

kylecarbs
Copy link
Member

@kylecarbskylecarbs commentedOct 2, 2022•
edited
Loading

This adds support for a newcoder_parameter type in Terraform which supports immutable, editable, and visually appealing parameters.

Examples:

image
image

Exposing the variable syntax in Terraform will become deprecated, and users will be forced to adopt thecoder_parameter data source. Here's an example of the syntax:

data"coder_parameter""example" {name="Example"type="string"option {name="First Option"value="first"  }option {name="Second Option"value="second"  }}

Todo:

  • Update thecreate CLI to work with the new parameters.
  • Show a "deprecated" message in the UI with instructions to switch to new parameters.
  • Convert example templates to use the new parameter type.
  • Edit the "workspace create" UI to be prettier!

kconley-sq, dcarrion87, bpmct, neezer, matifali, nudded, and andychisholm reacted with heart emojimatifali reacted with rocket emoji
@kylecarbskylecarbs self-assigned thisOct 2, 2022
@kylecarbskylecarbs changed the titlefeat: Addcoder_parameter typefeat: Addcoder_parameter data source for rich parametersOct 2, 2022
@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelOct 12, 2022
@kylecarbskylecarbs reopened thisOct 25, 2022
@kylecarbskylecarbs removed the staleThis issue is like stale bread. labelOct 25, 2022
@kylecarbs
Copy link
MemberAuthor

This PR has risen from the depths 👀

neezer, ntimo, bpmct, johnhenning, and andychisholm reacted with heart emoji

@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelNov 27, 2022
@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelDec 1, 2022
@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelDec 10, 2022
@dcarrion87
Copy link
Contributor

Noooooo! I hope this is still a thing?

@onlycs
Copy link

@bpmct

@kylecarbskylecarbs reopened thisJan 2, 2023
@kylecarbs
Copy link
MemberAuthor

This is still a thing! Holiday stale bot!

@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelJan 3, 2023
@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelJan 10, 2023
@ammario
Copy link
Member

@mtojek — you're taking this now, right?

@ammarioammario changed the titlefeat: Addcoder_parameter data source for rich parametersfeat: add parameters v2Jan 10, 2023
@ammarioammario changed the titlefeat: add parameters v2feat: add rich parametersJan 10, 2023
@mtojek
Copy link
Member

@mtojek — you're taking this now, right?

Yes, once I'm done with the task I'm working on at the moment -#3522.

I haven't started this one, just skimmed through the PR to understand the scope. We have a call about it tomorrow.

@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelJan 11, 2023
@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelJan 18, 2023
@dcarrion87
Copy link
Contributor

Bump for reopen.

@kylecarbs
Copy link
MemberAuthor

@dcarrion87 this is being implemented in chunks now! Follow#5574 instead.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@spikecurtisspikecurtisAwaiting requested review from spikecurtisspikecurtis will be requested when the pull request is marked ready for reviewspikecurtis is a code owner

@johnstcnjohnstcnAwaiting requested review from johnstcnjohnstcn will be requested when the pull request is marked ready for reviewjohnstcn is a code owner

Assignees

@kylecarbskylecarbs

Labels
staleThis issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@kylecarbs@dcarrion87@onlycs@ammario@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp