Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: static error page in applications handlers#4299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deansheather merged 6 commits intomainfromdean/devurls-error
Oct 4, 2022

Conversation

deansheather
Copy link
Member

@deansheatherdeansheather commentedOct 1, 2022•
edited
Loading

Closes#4040

  • Adds Bruno's new static error page fromfeat: Add static error page #4276 to most application error codepaths
  • Removessite.WithAPIResponse in favor of having the error page be the same static one for both path-based and subdomain-based applications

TODO:

  • All applications errors should use the same page, no httpapi at all
  • RemoveWithAPIResponse

@deansheatherdeansheather marked this pull request as ready for reviewOctober 4, 2022 11:24
@deansheatherdeansheather requested a review froma team as acode ownerOctober 4, 2022 11:24
@deansheatherdeansheather requested review fromcode-asher andkylecarbs and removed request fora teamOctober 4, 2022 11:24
@deansheatherdeansheather requested review fromKira-Pilot and removed request forcode-asherOctober 4, 2022 15:44
@deansheatherdeansheather merged commitd165d76 intomainOct 4, 2022
@deansheatherdeansheather deleted the dean/devurls-error branchOctober 4, 2022 16:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom proxy error page
4 participants
@deansheather@kylecarbs@Kira-Pilot@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp