Oct 4, 2022 · Sep 30, 2022 · Sep 30, 2022 · Sep 30, 2022 · Sep 30, 2022
diff --git a/site/jest.setup.ts b/site/jest.setup.ts
 // For now, I limited this to just 'error' - but failing on warnings
 // would be a nice next step! We may need to filter out some noise
 // from material-ui though.
 const CONSOLE_FAIL_TYPES = ["error" /* 'warn' */]
 const CONSOLE_FAIL_TYPES = ["error" /* 'warn' */] as const

 // Throw errors when a `console.error` or `console.warn` happens
 // by overriding the functions
 CONSOLE_FAIL_TYPES.forEach((logType: string) => {
  // Suppressing the no-explicit-any to override certain console functions for testing
  // eslint-disable-next-line @typescript-eslint/no-explicit-any
  const consoleAsAny = global.console as any
  // eslint-disable-next-line @typescript-eslint/no-explicit-any
  consoleAsAny[logType] = (format: string, ...args: any[]): void => {
 CONSOLE_FAIL_TYPES.forEach((logType: typeof CONSOLE_FAIL_TYPES[number]) => {
  global.console[logType] = <Type>(format: string, ...args: Type[]): void => {
    throw new Error(
      `Failing due to console.${logType} while running test!\n\n${util.format(format, ...args)}`,
    )
Original file line number	Diff line number	Diff line change
Expand Up		@@ -38,16 +38,12 @@ afterAll(() => server.close())
		// For now, I limited this to just 'error' - but failing on warnings
		// would be a nice next step! We may need to filter out some noise
		// from material-ui though.
		const CONSOLE_FAIL_TYPES = ["error" /* 'warn' */]
		const CONSOLE_FAIL_TYPES = ["error" /* 'warn' */] as const
Copy link ContributorAuthor jsjoeioSep 30, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Using`as const` narrows the type to string literals which is more correct.

		// Throw errors when a `console.error` or `console.warn` happens
		// by overriding the functions
		CONSOLE_FAIL_TYPES.forEach((logType: string) => {
		// Suppressing the no-explicit-any to override certain console functions for testing
		// eslint-disable-next-line @typescript-eslint/no-explicit-any
		const consoleAsAny = global.console as any
		// eslint-disable-next-line @typescript-eslint/no-explicit-any
		consoleAsAny[logType] = (format: string, ...args: any[]): void => {
		CONSOLE_FAIL_TYPES.forEach((logType: typeof CONSOLE_FAIL_TYPES[number]) => {
Copy link ContributorAuthor jsjoeioSep 30, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. here`logType` is limited to the options we specify in`CONSOLE_FAIL_TYPES`.
		global.console[logType] = <Type>(format: string, ...args: Type[]): void => {
Copy link ContributorAuthor jsjoeioSep 30, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Using the generic, we no longer need to use`any`.
		throw new Error(
		`Failing due to console.${logType} while running test!\n\n${util.format(format, ...args)}`,
		)
Expand Down