NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

feat: Add static error page#4276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

BrunoQuaresma merged 3 commits intomainfrombq/error

Oct 3, 2022

Merged

feat: Add static error page#4276

BrunoQuaresma merged 3 commits intomainfrombq/error

Oct 3, 2022

Conversation

Copy link

Collaborator

BrunoQuaresma commentedSep 30, 2022•
edited by deansheather
Loading

feat: Add static error page

cfd1e57

BrunoQuaresma self-assigned this

Sep 30, 2022

BrunoQuaresma requested a review froma team as acode owner

September 30, 2022 16:45

BrunoQuaresma requested review fromjsjoeio anddeansheather and removed request fora team

September 30, 2022 16:45

jsjoeio approved these changes

Sep 30, 2022

View reviewed changes

Copy link

Contributor

jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work!

kylecarbs reviewed

Sep 30, 2022

View reviewed changes

site/static/error.html OutdatedShow resolvedHide resolved

site/static/error.html Outdated

		<h1>502 - Bad Gateway</h1>
		<p>No service is running on port 3000. Make sure your process is running and try again.</p>
		<div class="button-group">
		<button id="retry">Retry</button>

Copy link

Member

kylecarbsSep 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Will this button be dynamic?

Copy link

CollaboratorAuthor

BrunoQuaresmaSep 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Probably. I think this is something that Go template can handle right?

Copy link

Member

deansheatherOct 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, controlled by.Error.RetryEnabled

feat: add go template variables to error.html

c066318

Copy link

Member

deansheather commentedOct 1, 2022

Added the go template variables and made a few changes:

Addedjustify-content: center to.button-group so the return to site button would be centered when the retry button was not present
Inlined thewindow.location.reload() to avoid making the JS conditional as well