- Notifications
You must be signed in to change notification settings - Fork928
feat: use app wildcards for apps if configured#4263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice work!
Uh oh!
There was an error while loading.Please reload this page.
codersdk/workspaceapps.go Outdated
| // `coder server` or via a hostname-based dev URL. If this is set to false | ||
| // and there is no app wildcard configured on the server, the app will not | ||
| // be accessible in the UI. | ||
| RelativePath bool `json:"relative_path"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we'll have to invert this on the provider to not break current deployments.
This is defaulting tofalse:https://github.com/coder/terraform-provider-coder/blob/main/provider/app.go#L62, which I believe would break everyone.
eg. removerelative_path and addsubdomain instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done!
- rename relative_path -> subdomain when referring to apps - migrate workspace_apps.relative_path to workspace_apps.subdomain- upgrade coder/coder terraform module to 0.5.0
| Command string `mapstructure:"command"` | ||
| Subdomain bool `mapstructure:"subdomain"` | ||
| // RelativePath is deprecated in favor of Subdomain. | ||
| RelativePath *bool `mapstructure:"relative_path"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think this needs to be a pointer anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We prefer the deprecated value over the new value if it's set, so we have to use a pointer for this to determine if it was explicitly set or not. I will add a comment
Uh oh!
There was an error while loading.Please reload this page.
subdomainto the WorkspaceApp struct.subdomainistrueand an app hostname is set.relative_pathand addssubdomain).relative_pathtosubdomainacross the codebase and in the database