Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(site): vscode eslint plugin working directory#423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
greyscaled merged 2 commits intomainfromvapurrmaid/fix-eslint
Mar 14, 2022

Conversation

greyscaled
Copy link
Contributor

@greyscaledgreyscaled commentedMar 13, 2022
edited
Loading

Summary

The .eslintrc.yaml is located in site, rather than the root of the repository. The VS Code plugin has a CWD of the repository root, so it looks for tsconfig.test.json in the root rather in site (resolving"./tsconfig.test.json")

Impact of Change

No more red squiggles in VS Code on every open TypeScript (ts, tsx) file insite. I verified that the VS Code ESLint Plugin corrected code automatically (and applied yellow and red squiggles as appropriate). This may not have worked identically before, so we should see an improvement to the TS development experience insite 🎉 🎊 .

See Also

Personal Note

This is my first primary author commit in this repo!

@greyscaledgreyscaled self-assigned thisMar 13, 2022
@greyscaledgreyscaled changed the titlefix(site): .eslintrc.yaml tsconfigRootDirfix(site): eslint tsconfigRootDirMar 13, 2022
Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great fix! Thanks@vapurrmaid 🥳

@greyscaled
Copy link
ContributorAuthor

ah crap, this breaks lint scripts...so it fixed one thing but broke another 😂. I will look into this!

kylecarbs reacted with eyes emoji

@codecov
Copy link

codecovbot commentedMar 13, 2022
edited
Loading

Codecov Report

Merging#423 (045e202) intomain (6c83907) willincrease coverage by0.97%.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff             @@##             main     #423      +/-   ##==========================================+ Coverage   67.19%   68.16%   +0.97%==========================================  Files         155      159       +4       Lines        9044     9226     +182       Branches       73       73              ==========================================+ Hits         6077     6289     +212+ Misses       2340     2316      -24+ Partials      627      621       -6
FlagCoverage Δ
unittest-go-macos-latest62.84% <ø> (?)
unittest-go-ubuntu-latest67.59% <ø> (+0.09%)⬆️
unittest-go-windows-202262.15% <ø> (?)
unittest-js64.07% <ø> (ø)
Impacted FilesCoverage Δ
pty/start_windows.go60.86% <0.00%> (ø)
pty/pty_windows.go68.25% <0.00%> (ø)
agent/usershell/usershell_darwin.go0.00% <0.00%> (ø)
agent/usershell/usershell_windows.go0.00% <0.00%> (ø)
coderd/provisionerdaemons.go57.06% <0.00%> (+0.54%)⬆️
coderd/users.go61.53% <0.00%> (+0.54%)⬆️
peer/channel.go83.62% <0.00%> (+0.58%)⬆️
codersdk/users.go68.42% <0.00%> (+1.75%)⬆️
coderd/parameter/compute.go74.07% <0.00%> (+2.22%)⬆️
coderd/parameters.go65.38% <0.00%> (+2.30%)⬆️
... and12 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update6c83907...045e202. Read thecomment docs.

Summary:The .eslintrc.yaml is located in site, rather than the root of therepository. The VS Code plugin has a CWD of the repository root, so itlooks for tsconfig.test.json in the root rather in site.See Also:-microsoft/vscode-eslint#196-typescript-eslint/typescript-eslint#251
@greyscaled
Copy link
ContributorAuthor

@kylecarbs Now that I realize the errors were specific to VS Code plugin, I just had to tell it where oursite project was (verified by researching the plugin issues). 🎉

kylecarbs reacted with thumbs up emoji

@greyscaledgreyscaled changed the titlefix(site): eslint tsconfigRootDirfix(site): vscode eslint plugin working directoryMar 13, 2022
@greyscaled
Copy link
ContributorAuthor

@kylecarbs I'm not authorized to merge the PR 😂. Are you able to set something up for me to be able to merge?

@kylecarbs
Copy link
Member

Oh... hahahah yes I'll fix now!

@kylecarbs
Copy link
Member

@vapurrmaid is there a message that displays? I'm not sure why merge would be blocked.

@greyscaled
Copy link
ContributorAuthor

@vapurrmaid is there a message that displays? I'm not sure why merge would be blocked.

Yea! Here's a screenshot and a link to that doc

authorize

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/about-protected-branches

@kylecarbs
Copy link
Member

@vapurrmaid does it work now?

@greyscaled
Copy link
ContributorAuthor

greyscaled commentedMar 13, 2022
edited
Loading

@vapurrmaid does it work now?

Yes 🙌🏻 , thank you 🎊 !

I have now officially contributed (as a primary commit author) to v2, very exciting 🎉 🎉

@greyscaledgreyscaled merged commit60f3cf6 intomainMar 14, 2022
@greyscaledgreyscaled deleted the vapurrmaid/fix-eslint branchMarch 14, 2022 00:02
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

@bryphe-coderbryphe-coderAwaiting requested review from bryphe-coder

Assignees

@greyscaledgreyscaled

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

3 participants
@greyscaled@kylecarbs@misskniss

[8]ページ先頭

©2009-2025 Movatter.jp