Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Remove "Starts at Manual" label#4179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 2 commits intomainfrommanualfix
Oct 3, 2022
Merged

fix: Remove "Starts at Manual" label#4179

kylecarbs merged 2 commits intomainfrommanualfix
Oct 3, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbskylecarbs commentedSep 23, 2022•
edited
Loading

Fixes#2798 and#4303.

@kylecarbskylecarbs self-assigned thisSep 23, 2022
@kylecarbskylecarbs requested a review froma team as acode ownerSeptember 23, 2022 19:47
@kylecarbskylecarbs requested review fromBrunoQuaresma and removed request fora teamSeptember 23, 2022 19:47
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The code looks good but we need some CSS changes when there is no label.

Screen Shot 2022-09-26 at 11 31 29

Looks like the border left is larger than the others.

kylecarbs and jsjoeio reacted with thumbs up emoji
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Left a comment but should be good to go after it is ready. PS: Check the Storybook previews after.

@kylecarbskylecarbsenabled auto-merge (squash)October 3, 2022 16:56
@kylecarbskylecarbs merged commit4f63555 intomainOct 3, 2022
@kylecarbskylecarbs deleted the manualfix branchOctober 3, 2022 17:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Starts at Manual" is confusing
2 participants
@kylecarbs@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp