Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: sync autostart helpers+values when toggled#4143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bpmct merged 2 commits intomainfrombpmct/autostart-input-fun
Sep 21, 2022

Conversation

bpmct
Copy link
Member

Fixes#3463

previous.behavior.mov
new.behavior.mov

@bpmctbpmct requested a review froma team as acode ownerSeptember 21, 2022 03:58
@bpmctbpmct requested review fromcode-asher andpresleyp and removed request fora team,presleyp andcode-asherSeptember 21, 2022 03:58
@presleyp
Copy link
Contributor

@ammario@Kira-Pilot I remember y'all weighing in on it being inconvenient to clear autostart/stop values when the switch is turned off. Are you okay with going back to that behavior?

@Kira-Pilot
Copy link
Member

@presleyp@bpmct I think this is fine for now. If the form gets longer, maybe we preserve user-entered values or drop a warning modal in the page.

Copy link
Member

@ammarioammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems subjective which approach is best, but either behavior is fine to me.

@bpmctbpmct merged commit9347545 intomainSep 21, 2022
@bpmctbpmct deleted the bpmct/autostart-input-fun branchSeptember 21, 2022 17:59
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@presleyppresleyppresleyp approved these changes

@ammarioammarioammario approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve UX of disabled auto-start/stop
4 participants
@bpmct@presleyp@Kira-Pilot@ammario
[8]ページ先頭
©2009-2025 Movatter.jp