- Notifications
You must be signed in to change notification settings - Fork928
fix: Setup redirect#4064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix: Setup redirect#4064
Uh oh!
There was an error while loading.Please reload this page.
Conversation
code-asher left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good! Verified it works on my deployment.
Out of curiosity it looks like the auth xservice is maybe supposed to do a redirect? Not sure if that means the service is broken or if these lines are actually doing something else or these lines should be removed:
coder/site/src/xServices/auth/authXService.ts
Lines 410 to 411 inec453f0
| waitingForTheFirstUser:{ | |
| entry:"redirectToSetupPage", |
BrunoQuaresma commentedSep 15, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@code-asher good point. I will take a look into that. Since our "guards redirects" are made using Routes, I'm removing this and updating the LoginPage. |
Fix#4050