Sep 14, 2022 · Sep 13, 2022 · Sep 14, 2022
diff --git a/cli/login.go b/cli/login.go

 hasInitialUser, err := client.HasFirstUser(cmd.Context())
 if err != nil {
 return xerrors.Errorf("has initial user: %w", err)
 return xerrors.Errorf("Failed to check server %q for first user, is the URL correct and is coder accessible from your browser? Error -has initial user: %w", serverURL.String(), err)
 }
 if !hasInitialUser {
 _, _ = fmt.Fprintf(cmd.OutOrStdout(), caret+"Your Coder deployment hasn't been set up!\n")
diff --git a/cli/login_test.go b/cli/login_test.go

 import (
 "context"
 "fmt"
 "testing"

 "github.com/stretchr/testify/assert"
 require.Error(t, err)
 })

 t.Run("InitialUserBadLoginURL", func(t *testing.T) {
 t.Parallel()
 badLoginURL := "https://fcca2077f06e68aaf9"
 root, _ := clitest.New(t, "login", badLoginURL)
 err := root.Execute()
 errMsg := fmt.Sprintf("Failed to check server %q for first user, is the URL correct and is coder accessible from your browser?", badLoginURL)
 require.ErrorContains(t, err, errMsg)
 })

 t.Run("InitialUserTTY", func(t *testing.T) {
 t.Parallel()
 client := coderdtest.New(t, nil)
Original file line number	Diff line number	Diff line change
Expand Up		@@ -83,7 +83,7 @@ func login() *cobra.Command {

		hasInitialUser, err := client.HasFirstUser(cmd.Context())
		if err != nil {
		return xerrors.Errorf("has initial user: %w", err)
		return xerrors.Errorf("Failed to check server %q for first user, is the URL correct and is coder accessible from your browser? Error -has initial user: %w", serverURL.String(), err)
Copy link ContributorAuthor jsjoeioSep 14, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Thought about this a bit more last night...Since this is user-facing, I think the friendly error message should be included in the test assertion. Otherwise, it can be removed and the test would still pass. Then we'd have a working CLI with poor UX. Instead, we want to ensure we have good UX.
		}
		if !hasInitialUser {
		_, _ = fmt.Fprintf(cmd.OutOrStdout(), caret+"Your Coder deployment hasn't been set up!\n")
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2,6 +2,7 @@ package cli_test

		import (
		"context"
		"fmt"
		"testing"

		"github.com/stretchr/testify/assert"
Expand All		@@ -23,6 +24,15 @@ func TestLogin(t *testing.T) {
		require.Error(t, err)
		})

		t.Run("InitialUserBadLoginURL", func(t *testing.T) {
		t.Parallel()
		badLoginURL := "https://fcca2077f06e68aaf9"
		root, _ := clitest.New(t, "login", badLoginURL)
		err := root.Execute()
		errMsg := fmt.Sprintf("Failed to check server %q for first user, is the URL correct and is coder accessible from your browser?", badLoginURL)
		require.ErrorContains(t, err, errMsg)
		})

		t.Run("InitialUserTTY", func(t *testing.T) {
		t.Parallel()
		client := coderdtest.New(t, nil)
Expand Down