- Notifications
You must be signed in to change notification settings - Fork928
feat: add workspace auditing#3966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
d60bec5 to6ac2929Compare| var ( | ||
| organization = httpmw.OrganizationParam(r) | ||
| apiKey = httpmw.APIKey(r) | ||
| aReq, commitAudit = audit.InitRequest[database.Workspace](rw, &audit.RequestParams{ | ||
| Features: api.FeaturesService, | ||
| Log: api.Logger, | ||
| Request: r, | ||
| Action: database.AuditActionCreate, | ||
| }) | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's shorter to not put these in a var block, so I'd rather have them out. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm sorta partial to just having a var block at the top of each handler, I think it separates them cleanly from the actual code. Don't feel super strongly though, but I think it should be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
No description provided.