Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: Turn predictable action arguments on#3964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
presleyp merged 4 commits intomainfrompresleyp/xstate-actions
Sep 13, 2022

Conversation

presleyp
Copy link
Contributor

@presleyppresleyp commentedSep 9, 2022
edited
Loading

A recent update gave us a message that we should turnpredictableActionArguments on whenever we create an XState machine. Here's what it does:https://xstate.js.org/docs/guides/actions.html

While I was in there, I put some of the keys in a set order just for consistency.

The only case I could find where this should have an effect is inrefreshTimelines in the workspace xService, and it should actually make the code behave more as intended than it was before (theassign action is put after another action but previously, would be executed first).

BrunoQuaresma reacted with thumbs up emoji
@presleyppresleyp requested a review froma team as acode ownerSeptember 9, 2022 00:37
@presleyppresleyp requested review fromKira-Pilot andBrunoQuaresma and removed request fora teamSeptember 9, 2022 00:37
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@presleyppresleyp merged commit99a7a8d intomainSep 13, 2022
@presleyppresleyp deleted the presleyp/xstate-actions branchSeptember 13, 2022 16:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@presleyp@BrunoQuaresma@Kira-Pilot

[8]ページ先頭

©2009-2025 Movatter.jp