Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Improve experience with local SSH keys#3835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 7 commits intomainfrommafredri/bring-your-own-ssh-keys
Sep 12, 2022

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedSep 2, 2022•
edited
Loading

This change means that users can place SSH keys in the default locations for OpenSSH, like~/.ssh/id_rsa and it will be automatically picked up (as per a default OpenSSH experience).

Fixes#3126

Notes:

  • I wanted to implement a-test.homedir flag to test the SSH fallback key locations, however, settingHOME=/tmp/ seems to have no effect on where OpenSSH looks for the config :(
  • Although thisfixesCannot bring your own SSH key to clone #3126, we'll want to break out some Windows related discussions from there to:
    1. Fix SSH agent forwarding on Windows
    2. Potentially refactor this into using our own proxy agent, once our Windows SSH agent story is fixed

bpmct reacted with heart emoji
@mafredrimafredri self-assigned thisSep 2, 2022
@mafredrimafredri requested a review froma teamSeptember 2, 2022 14:15
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

TIL ssh -g

cli/gitssh.go Outdated
"identityfile ~/.ssh/id_xmss",
}, "\n")

// praseIdentityFilesForHost uses ssh -G to discern what SSH keys have
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
//praseIdentityFilesForHost uses ssh -G to discern what SSH keys have
//parseIdentityFilesForHost uses ssh -G to discern what SSH keys have

mafredri reacted with laugh emoji
mafredriand others added7 commitsSeptember 5, 2022 12:44
This change means that users can place SSH keys in the default locationsfor OpenSSH, like `~/.ssh/id_rsa` and it will be automatically pickedup (as per a default OpenSSH experience).Fixes#3126
Co-authored-by: Dean Sheather <dean@deansheather.com>
@mafredrimafredriforce-pushed themafredri/bring-your-own-ssh-keys branch from3ef314f to0d413fbCompareSeptember 5, 2022 09:47
@mafredrimafredri merged commitd0b02e5 intomainSep 12, 2022
@mafredrimafredri deleted the mafredri/bring-your-own-ssh-keys branchSeptember 12, 2022 14:26
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot bring your own SSH key to clone
2 participants
@mafredri@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp