NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

feat: Add portforward to the UI#3812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

BrunoQuaresma merged 8 commits intomainfrombq/3516

Sep 13, 2022

Merged

feat: Add portforward to the UI#3812

BrunoQuaresma merged 8 commits intomainfrombq/3516

Sep 13, 2022

Conversation

Copy link

Collaborator

BrunoQuaresma commentedSep 1, 2022

Preview:

Blocked by#3753

Closes#3516

feat: Add portforward to the UI

a6f976e

BrunoQuaresma self-assigned this

Sep 1, 2022

BrunoQuaresma requested a review froma team as acode owner

September 1, 2022 18:52

BrunoQuaresma requested review frompresleyp and removed request fora team

September 1, 2022 18:52

presleyp reviewed

Sep 1, 2022

View reviewed changes

site/src/components/PortForwardButton/PortForwardButton.tsx OutdatedShow resolvedHide resolved

presleyp approved these changes

Sep 1, 2022

View reviewed changes

Copy link

Member

bpmct commentedSep 1, 2022

A note from#1624:

If an admin doesn't set up a wildcard domain, the port forwarding dropdown should not use a subdomain.
Coder Classic entirely disabled port forwarding via the dashboard when coderd. devurlsHost was not set.
@bpmct suggestion: use a deployment-wide environment variable to enable subdomain apps. When disabled, use path URLs and link to docs to enable subdomains via the dropdown (many apps don't work by default as a path).

Update site/src/components/PortForwardButton/PortForwardButton.tsx

8556bc9

Co-authored-by: Presley Pizzo <1290996+presleyp@users.noreply.github.com>

Copy link

CollaboratorAuthor

BrunoQuaresma commentedSep 2, 2022

@bpmct thanks for bringing it to my attention!

BrunoQuaresma added3 commits

September 6, 2022 14:12

Merge branch 'main' of github.com:coder/coder into bq/3516

8e7f8bd

Add CODER_ENABLE_WILDCARD_APPS env var

ba52fed

Merge branch 'bq/3516' of github.com:coder/coder into bq/3516

1072f96

Copy link

CollaboratorAuthor

BrunoQuaresma commentedSep 6, 2022

@bpmct are these "URL interpolations" right?https://github.com/coder/coder/pull/3812/files#diff-5390f341c0bb6b03cb273d6cb97525b6c3f607dc8c5decbc9cfafd2dd7e0d46dR32-R35

jsjoeio reviewed

Sep 6, 2022

View reviewed changes

site/src/components/PortForwardButton/PortForwardButton.tsxShow resolvedHide resolved

jsjoeio approved these changes

Sep 6, 2022

View reviewed changes

site/src/components/PortForwardButton/PortForwardButton.tsxShow resolvedHide resolved

jsjoeio approved these changes

Sep 6, 2022

View reviewed changes

BrunoQuaresma added3 commits

September 9, 2022 17:24

Fix portforward link

f0f7156

Remove t file

e965305

Merge branch 'main' of github.com:coder/coder into bq/3516

38a0f7b

BrunoQuaresma mentioned this pull request

Sep 12, 2022

feat: Add serving applications on subdomains and port-based proxying#3753

Merged

BrunoQuaresma merged commit0552c36 intomain

Sep 13, 2022

BrunoQuaresma deleted the bq/3516 branch

September 13, 2022 20:41

BrunoQuaresma mentioned this pull request

Sep 13, 2022

Add link to open any port in dashboard#1624

Closed

kylecarbs reviewed

Sep 13, 2022

View reviewed changes

site/src/components/PortForwardButton/PortForwardButton.tsx

		const [port, setPort] = useState("3000")
		const { location } = window
		const urlExample =
		process.env.CODER_ENABLE_WILDCARD_APPS === "true"

Copy link

Member

kylecarbsSep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This will be compiled by webpack, and isn't a dynamic environment variable at runtime. If we want to have a proper environment variable passed through, it'll have to come via the backend.