Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Create winget-submission.yml#3729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
matifali wants to merge3 commits intocoder:mainfrommatifali:patch-1
Closed

Create winget-submission.yml#3729

matifali wants to merge3 commits intocoder:mainfrommatifali:patch-1

Conversation

matifali
Copy link
Member

@matifalimatifali commentedAug 29, 2022
edited
Loading

This PR adds a GitHub action to publish every release to winget

Subtasks

  • packageFileName: coder_${VERSION}_windows_amd64.zip # Need to get VERSION from latest release to use here
  • packageId: MyPackageIdInWinget # Need to ge an official Winget Package ID
  • secrets.Project_PAT # generate aPAT with the scope public_repo and add it to your project's secrets with the nameProject_PAT.
  • Resolvewingetcreate issue with portable apps.

Partiallyresolves#3714

kylecarbs, bpmct, and matifali reacted with thumbs up emoji
  packageFileName: coder_${VERSION}_windows_amd64.zip    # Need to get VERSION from latest release to use here  packageId: MyPackageIdInWinget  # Need to ge an official Winget Package IDecrets.Project_PAT  # generate a PAT with the scope public_repo and add it to the secrets of your project with the name Project_PAT
@matifalimatifali marked this pull request as ready for reviewAugust 29, 2022 15:07
@matifalimatifali marked this pull request as draftAugust 29, 2022 15:07
@matifali
Copy link
MemberAuthor

Can you take a look at this?@bpmct

@matifalimatifali marked this pull request as ready for reviewSeptember 8, 2022 08:55
@bpmct
Copy link
Member

Hey! Sorry for the late response - I'm looking at publishing the first package now so we can get the ID and then update via this action

matifali reacted with thumbs up emoji

@matifali
Copy link
MemberAuthor

Hey! Sorry for the late response - I'm looking at publishing the first package now so we can get the ID and then update via this action

Sure, link it here when you are done.

@bpmct
Copy link
Member

bpmct commentedSep 9, 2022
edited
Loading

@matifali It seems like Winget very recently added support for portable apps (standalone .exe) and it's somewhat new and experimental. For example, I can't figure out how to create the app withwingetcreate https://github.com/coder/coder/releases/download/v0.8.14/coder_0.8.14_windows_amd64.zip as it's expecting a MSI file or similar, not a standalone exe.

Ah, I just saw this in the v1.3 release.

Note: TheWindows Package Manager Community Repository does not accept portable applications. They will not be accepted until after 1.3 is Generally Available and has been rolled out to the majority of Windows systems via the automatic upgrade from the Microsoft Store. Users may test with local manifests.

I also haven't been able to test with a local manifest. This does not seem to be working for me. Any ideas?

# turn on install from filewinget settings--enable LocalManifestFiles# installwinget install-m coder.yaml
Id:Coder.CoderName:CoderDescription:Remote development environments on your infrastructure provisioned with TerraformVersion:0.8.14Publisher:CoderLicense:AGPL-3.0, Unknown licenses foundHomepage:https://github.com/coder/coderTags:portableInstallers:    -Arch:x64InstallerType:exeUrl:https://github.com/coder/coder/releases/download/v0.8.14/coder_0.8.14_windows_amd64.zipSha256:435cc6a195c7af4a210d90ed78f59f802407caf6740986087f4e2ae983b7d3f8

@matifali
Copy link
MemberAuthor

matifali commentedSep 9, 2022
edited
Loading

By modifying the manifest file as per the latestsingelton schema, although for community repo submission, we need three files schemas (wingetcreate will generate them automatically)

PackageIdentifier:Coder.CoderPackageVersion:0.8.14PackageLocale:en-USPublisher:CoderPackageName:CoderLicense:AGPL-3.0, Unknown licenses foundShortDescription:Remote development environments on your infrastructure provisioned with TerraformInstallers: -Architecture:x64InstallerType:portableInstallerLocale:en-USCommands:[coder]InstallerUrl:https://github.com/coder/coder/releases/download/v0.8.14/coder_0.8.14_windows_amd64.zipInstallerSha256:435cc6a195c7af4a210d90ed78f59f802407caf6740986087f4e2ae983b7d3f8InstallModes:    -silentManifestType:singletonManifestVersion:1.2.0

I was able to install it locally and reached up to this point.

PS C:\Users\matif> winget install-m coder.yamlFound Coder [Coder.Coder] Version0.8.14This application is licensed to you by its owner.Microsoft is not responsiblefor, nor does it grant any licenses to, third-party packages.Downloading https://github.com/coder/coder/releases/download/v0.8.14/coder_0.8.14_windows_amd64.zip  ██████████████████████████████112 MB/112 MBSuccessfully verified installer hashStarting package install...Overwriting existing file: C:\Users\matif\AppData\Local\Microsoft\WinGet\Links\coder_0.8.14_windows_amd64.exeSuccessfully installedPS C:\Users\matif> coderResourceUnavailable: Program'coder.exe' failed to run: An error occurred trying to startprocess'C:\Users\matif\AppData\Local\Microsoft\WinGet\Links\coder.exe' with working directory'C:\Users\matif'. The specified executable is not a valid applicationfor this OS platform.At line:1 char:1+ coder+ ~~~~~.
bpmct reacted with thumbs up emoji

@matifali
Copy link
MemberAuthor

matifali commentedSep 9, 2022
edited
Loading

@bpmct

For example, I can't figure out how to create the app with wingetcreatehttps://github.com/coder/coder/releases/download/v0.8.14/coder_0.8.14_windows_amd64.zip as it's expecting an MSI file or similar, not a standalone exe.

wingetcreate1.1.2.0 does support creating manifests for portable apps, but I am not sure if it accepts azip instead of anexe
May be coder should publish.exe for windows instead of.zip

There seems to be a known bugmicrosoft/winget-create#302 for why this is not working.

@bpmct
Copy link
Member

Hmm ok. I will follow the issue there. It seems like this doesn't work with exe either, given that issue and the fact that it unzipped things fine

@bpmct
Copy link
Member

bpmct commentedSep 19, 2022
edited
Loading

ResourceUnavailable: Program 'coder.exe' failed to run: An error occurred trying to start process 'C:\Users\matif\AppData\Local\Microsoft\WinGet\Links\coder.exe' with working directory 'C:\Users\matif'. The specified executable is not a valid application for this OS platform.At line:1 char:1

How to we get past this? I ran into the same thing and it seems to be exclusive to winget

@matifali
Copy link
MemberAuthor

matifali commentedSep 20, 2022
edited
Loading

ResourceUnavailable: Program 'coder.exe' failed to run: An error occurred trying to start process 'C:\Users\matif\AppData\Local\Microsoft\WinGet\Links\coder.exe' with working directory 'C:\Users\matif'. The specified executable is not a valid application for this OS platform.At line:1 char:1

How to we get past this? I ran into the same thing and it seems to be exclusive to winget

Yes, it seems like it is installing it, and binary is on the path but can't execute. I will try to find the reason soon. It has to do something with 'App Execution Alias'.

@matifali
Copy link
MemberAuthor

matifali commentedSep 23, 2022
edited
Loading

https://github.com/microsoft/winget-pkgs/tree/master/manifests/r/RussellBanks/winfetch/2.4.1
Check this for reference. This is a portable app published onwinget. It is usingYamlCreate.ps1 to generate manifests.

@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelOct 1, 2022
@deansheather
Copy link
Member

Now that we have the installer this can be reopened and updated. The installer URL should be the asset URL from the release (e.g.https://github.com/coder/coder/releases/download/v0.11.0/coder_0.11.0_windows_amd64_installer.exe) and should have the same fields as the package I submitted manually:microsoft/winget-pkgs#86238

Comment on lines +7 to +10
env:
version: "$(git describe --tags --abbrev=0)"
packageFileName: coder_${version}_windows_amd64.zip
packageId: Coder.Coder # Most probably the id of coder package
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

These env vars should be inUPPER_SNAKE_CASE format like normal env vars, and should be referenced by"$NAME" in the script below instead of using${env:NAME} as they have different semantics

types: [published]

env:
version: "$(git describe --tags --abbrev=0)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For consistency we should stick to./scripts/version.sh. Also, instead of having an evaluated statement here (which doesn't get evaluated instantly), you should just have these be variables in the script instead.

@@ -0,0 +1,23 @@
name: Submit package to Windows Package Manager Community Repository
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could just be calledsubmit-packages.yml and"Submit packages" so we can use it for other package managers in the future

@ghuntleyghuntley mentioned this pull requestNov 14, 2022
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather left review comments

Assignees
No one assigned
Labels
staleThis issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows packages (winget, choco, etc)
3 participants
@matifali@bpmct@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp