- Notifications
You must be signed in to change notification settings - Fork928
Create winget-submission.yml#3729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
packageFileName: coder_${VERSION}_windows_amd64.zip # Need to get VERSION from latest release to use here packageId: MyPackageIdInWinget # Need to ge an official Winget Package IDecrets.Project_PAT # generate a PAT with the scope public_repo and add it to the secrets of your project with the name Project_PAT
Can you take a look at this?@bpmct |
Hey! Sorry for the late response - I'm looking at publishing the first package now so we can get the ID and then update via this action |
Sure, link it here when you are done. |
bpmct commentedSep 9, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@matifali It seems like Winget very recently added support for portable apps (standalone .exe) and it's somewhat new and experimental. For example, I can't figure out how to create the app with Ah, I just saw this in the v1.3 release.
I also haven't been able to test with a local manifest. This does not seem to be working for me. Any ideas? # turn on install from filewinget settings--enable LocalManifestFiles# installwinget install-m coder.yaml Id:Coder.CoderName:CoderDescription:Remote development environments on your infrastructure provisioned with TerraformVersion:0.8.14Publisher:CoderLicense:AGPL-3.0, Unknown licenses foundHomepage:https://github.com/coder/coderTags:portableInstallers: -Arch:x64InstallerType:exeUrl:https://github.com/coder/coder/releases/download/v0.8.14/coder_0.8.14_windows_amd64.zipSha256:435cc6a195c7af4a210d90ed78f59f802407caf6740986087f4e2ae983b7d3f8 |
matifali commentedSep 9, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
By modifying the manifest file as per the latestsingelton schema, although for community repo submission, we need three files schemas (wingetcreate will generate them automatically) PackageIdentifier:Coder.CoderPackageVersion:0.8.14PackageLocale:en-USPublisher:CoderPackageName:CoderLicense:AGPL-3.0, Unknown licenses foundShortDescription:Remote development environments on your infrastructure provisioned with TerraformInstallers: -Architecture:x64InstallerType:portableInstallerLocale:en-USCommands:[coder]InstallerUrl:https://github.com/coder/coder/releases/download/v0.8.14/coder_0.8.14_windows_amd64.zipInstallerSha256:435cc6a195c7af4a210d90ed78f59f802407caf6740986087f4e2ae983b7d3f8InstallModes: -silentManifestType:singletonManifestVersion:1.2.0 I was able to install it locally and reached up to this point. PS C:\Users\matif> winget install-m coder.yamlFound Coder [Coder.Coder] Version0.8.14This application is licensed to you by its owner.Microsoft is not responsiblefor, nor does it grant any licenses to, third-party packages.Downloading https://github.com/coder/coder/releases/download/v0.8.14/coder_0.8.14_windows_amd64.zip ██████████████████████████████112 MB/112 MBSuccessfully verified installer hashStarting package install...Overwriting existing file: C:\Users\matif\AppData\Local\Microsoft\WinGet\Links\coder_0.8.14_windows_amd64.exeSuccessfully installedPS C:\Users\matif> coderResourceUnavailable: Program'coder.exe' failed to run: An error occurred trying to startprocess'C:\Users\matif\AppData\Local\Microsoft\WinGet\Links\coder.exe' with working directory'C:\Users\matif'. The specified executable is not a valid applicationfor this OS platform.At line:1 char:1+ coder+ ~~~~~. |
matifali commentedSep 9, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There seems to be a known bugmicrosoft/winget-create#302 for why this is not working. |
Hmm ok. I will follow the issue there. It seems like this doesn't work with exe either, given that issue and the fact that it unzipped things fine |
bpmct commentedSep 19, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
How to we get past this? I ran into the same thing and it seems to be exclusive to winget |
matifali commentedSep 20, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yes, it seems like it is installing it, and binary is on the path but can't execute. I will try to find the reason soon. It has to do something with 'App Execution Alias'. |
matifali commentedSep 23, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
https://github.com/microsoft/winget-pkgs/tree/master/manifests/r/RussellBanks/winfetch/2.4.1 |
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
Now that we have the installer this can be reopened and updated. The installer URL should be the asset URL from the release (e.g. |
env: | ||
version: "$(git describe --tags --abbrev=0)" | ||
packageFileName: coder_${version}_windows_amd64.zip | ||
packageId: Coder.Coder # Most probably the id of coder package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
These env vars should be inUPPER_SNAKE_CASE
format like normal env vars, and should be referenced by"$NAME"
in the script below instead of using${env:NAME}
as they have different semantics
types: [published] | ||
env: | ||
version: "$(git describe --tags --abbrev=0)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For consistency we should stick to./scripts/version.sh
. Also, instead of having an evaluated statement here (which doesn't get evaluated instantly), you should just have these be variables in the script instead.
Uh oh!
There was an error while loading.Please reload this page.
@@ -0,0 +1,23 @@ | |||
name: Submit package to Windows Package Manager Community Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could just be calledsubmit-packages.yml
and"Submit packages"
so we can use it for other package managers in the future
Uh oh!
There was an error while loading.Please reload this page.
This PR adds a GitHub action to publish every release to winget
Subtasks
packageFileName: coder_${VERSION}_windows_amd64.zip
# Need to get VERSION from latest release to use herepackageId: MyPackageIdInWinget
# Need to ge an official Winget Package IDsecrets.Project_PAT
# generate aPAT
with the scope public_repo and add it to your project's secrets with the nameProject_PAT
.wingetcreate
issue with portable apps.Partiallyresolves#3714