- Notifications
You must be signed in to change notification settings - Fork928
make agent 'connecting' visually different from 'connected'#3675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems reasonable to me!
(reviewing in favor of@BrunoQuaresma who is on PTO)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Bruno is out so I'll weigh in - I think the distinction is desirable and that blue/primary is a good choice.
Since "Connected" status is green, I wanted to make "Connecting" distinct visually, so I used blue.
Before:
After:
Connected (for comparison):
