Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Template settings fixes/kira pilot#3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Kira-Pilot merged 13 commits intomainfromtemplate-settings-fixes/kira-pilot
Aug 24, 2022

Conversation

Kira-Pilot
Copy link
Member

resolves#3640 from a FE perspective:

  • TTL is now displayed/entered in hours
  • TTL cannot be greater than 7 days (168 hours)
  • TTL has validation error if above condition is not met
  • TTL has helper text to add clarity
  • Description has max char count of 128
  • Description has validation error if above condition is not met
    Screen Shot 2022-08-24 at 10 34 48 AM

Screen Shot 2022-08-24 at 11 12 34 AM

@Kira-PilotKira-Pilot requested a review froma team as acode ownerAugust 24, 2022 15:18
@Kira-PilotKira-Pilot requested review fromjsjoeio andjohnstcn and removed request fora teamAugust 24, 2022 15:18
Co-authored-by: Cian Johnston <cian@coder.com>
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking good! Backend ✅

Copy link
Contributor

@jsjoeiojsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great 🚀

@Kira-PilotKira-Pilot merged commit57c202d intomainAug 24, 2022
@Kira-PilotKira-Pilot deleted the template-settings-fixes/kira-pilot branchAugust 24, 2022 18:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jsjoeiojsjoeiojsjoeio left review comments

@johnstcnjohnstcnjohnstcn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: template settings
3 participants
@Kira-Pilot@jsjoeio@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp