Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: template: enforce bounds of template max_ttl#3662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 8 commits intomainfromcj/gh-3640/template-max-ttl-bounds
Aug 24, 2022

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedAug 24, 2022•
edited
Loading

This PR makes the following changes:

  • enforces lower and upper limits on templatemax_ttl_ms
  • adds a migration to enforce 7-day cap onmax_ttl
  • allows setting templatemax_ttl to 0
  • updates template edit CLI help to be clearer

Partiallyfixes#3640

matifali reacted with thumbs up emoji
@johnstcnjohnstcn requested review froma team andKira-PilotAugust 24, 2022 12:43
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Copy link
Member

@Kira-PilotKira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yay!

@johnstcnjohnstcn merged commiteba753b intomainAug 24, 2022
@johnstcnjohnstcn deleted the cj/gh-3640/template-max-ttl-bounds branchAugust 24, 2022 14:45
@matifali
Copy link
Member

What does settingmax_ttl to 0 mean? Turning off auto stop?

@johnstcn
Copy link
MemberAuthor

johnstcn commentedAug 24, 2022•
edited
Loading

What does settingmax_ttl to 0 mean? Turning off auto stop?

Autostop can be enabled or disabled on a per-workspace basis.max_ttl controls the maximum workspace lifetime.

matifali reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@EmyrkEmyrkEmyrk approved these changes

@deansheatherdeansheatherdeansheather approved these changes

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: template settings
5 participants
@johnstcn@matifali@Emyrk@deansheather@Kira-Pilot
[8]ページ先頭
©2009-2025 Movatter.jp