Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Clean upcoder config-ssh dry-run behavior#3660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 4 commits intomainfrommafredri/config-ssh-dry-run-cleanup
Aug 24, 2022

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedAug 24, 2022
edited
Loading

Now the dry-run won't ask for a final confirm at the end, it has felt weird every time I've used it.

This commit also drops old deprecated code.

Dry run:

❯ ./coder config-ssh -o ForwardAgent=yes -n> New options differ from previous options:  New options:    * ssh-option: ForwardAgent=yes  Previous options:    * ssh-option: ForwardAgent=no  Use new options? (yes/no) yesDry run, the following changes would be made to your SSH configuration:  * Use new SSH option  * Update the coder section in /home/maf/.ssh/config--- /home/maf/.ssh/config+++ /home/maf/.ssh/config@@ -20,10 +20,10 @@ # changes will be lost when running "coder config-ssh". # # Last config-ssh options:-# :ssh-option=ForwardAgent=no+# :ssh-option=ForwardAgent=yes # Host coder.test-ForwardAgent=no+ForwardAgent=yes HostName coder.test ConnectTimeout=0 StrictHostKeyChecking=no

Run that made changes:

❯ ./coder config-ssh -o ForwardAgent=yes -yYou should now be able to ssh into your workspace.For example, try running:$ ssh coder.test

No changes:

❯ ./coder config-ssh -o ForwardAgent=yes -yNo changes to make.

Fixes#2982

@mafredrimafredri self-assigned thisAug 24, 2022
@mafredrimafredri requested a review froma teamAugust 24, 2022 12:28
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Makes sense 👍

@mafredrimafredri merged commit343d118 intomainAug 24, 2022
@mafredrimafredri deleted the mafredri/config-ssh-dry-run-cleanup branchAugust 24, 2022 13:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@EmyrkEmyrkEmyrk approved these changes

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI:coder config-ssh --dry-run suggests to connect to workspace even config was not updated yet
3 participants
@mafredri@johnstcn@Emyrk

[8]ページ先頭

©2009-2025 Movatter.jp