Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: k8s example persistence & coder images#3619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ericpaulsen merged 4 commits intomainfromk8s-template-pvc
Aug 24, 2022

Conversation

ericpaulsen
Copy link
Member

@ericpaulsenericpaulsen commentedAug 22, 2022•
edited
Loading

this PR looks to address@ammario's feedback in#3588 by adding persistence to our k8s example template.

it also removes the VS Code dev container images in favor ofCoder's enterprise images. The dev container images used/home/vscode, which contained shell scripts/customizations that would be wiped with a/home/vscode volume mount.

open to thoughts/feedback on removing the dev container images.

cra1gg and bpmct reacted with heart emoji
Copy link
Member

@ammarioammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for knocking this out. I didn't test it, but I assume you did. Feel free to merge if that's the case.

ericpaulsen reacted with thumbs up emoji
@ammario
Copy link
Member

And, I do think it's odd how there are multiple containers. That seems like a niche use case.

@ericpaulsen
Copy link
MemberAuthor

And, I do think it's odd how there are multiple containers. That seems like a niche use case.

i agree - i originally considered reducing it to one container. i'll push commit reflecting this, and also includecode-server in the template (something we should do for all of our examples).

ammario reacted with thumbs up emoji

@bpmct
Copy link
Member

bpmct commentedAug 22, 2022•
edited
Loading

And, I do think it's odd how there are multiple containers. That seems like a niche use case.

This template is calledkubernetes-multi-service so we'll need to change the name to reflect that it's no longer highlighting that use case.

I also noticed disk size & controls was removed. Was this to prevent breaking changes?

nvm

ericpaulsen reacted with thumbs up emoji

@ericpaulsenericpaulsen merged commitca3c049 intomainAug 24, 2022
@ericpaulsenericpaulsen deleted the k8s-template-pvc branchAugust 24, 2022 16:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ammarioammarioammario approved these changes

@sharkymarksharkymarkAwaiting requested review from sharkymark

@bpmctbpmctAwaiting requested review from bpmct

Assignees

@ericpaulsenericpaulsen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@ericpaulsen@ammario@bpmct@sharkymark
[8]ページ先頭
©2009-2025 Movatter.jp