- Notifications
You must be signed in to change notification settings - Fork928
Build enterprise coder binary by default#3517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Spike Curtis <spike@coder.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FE ✅
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I believe this would makeUnknown appear in GitHub for the license field.
Can we makeLICENSE.agpl namedLICENSE instead? And still have the Enterprise license?
| func main() { | ||
| rand.Seed(time.Now().UnixMicro()) | ||
| cmd, err := cli.Root().ExecuteC() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do we plan on having a separate CLI package to maintain? How do we imagine this working?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There will eventually be a separate enterprisecli package, because CLI commands for enterprise features will be in it. It will import all the core commands from the AGPLcli package.
Signed-off-by: Spike Curtis <spike@coder.com>
Fixes#3277
We now build enterprise binary by default. If anyone wants just the AGPL code, they can use our build scripts with
--agplflag.(Note that this PR doesn't introduce any enterprise code; the main.go is just a direct copy of the AGPL version)