Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: hiding agent status on stopped workspaces#3512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Kira-Pilot merged 4 commits intomainfromhide-agent-status/kira-pilot
Aug 17, 2022

Conversation

Kira-Pilot
Copy link
Member

resolves#3484

We have an issue where workspace agent statuses are 'connecting' after a workspace has stopped. After chatting with@bpmct, we have decided to hide the agent status on stopped workspaces. We have also created tickets to address the agent status on the BE (see#3510 and#3511). This PR addresses hiding the status in the UI, only.

Before

Screen Shot 2022-08-15 at 11 52 16 AM

After

Screen Shot 2022-08-15 at 12 38 53 PM

ammario and jsjoeio reacted with thumbs up emoji
@Kira-PilotKira-Pilot requested a review froma team as acode ownerAugust 15, 2022 17:29
error = "Error",
loading = "Loading",
}

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I moved this out of a component directory and into our util file so we can have properly typed statuses.

Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me! Sorry for the slow review!

Co-authored-by: Joe Previte <jjprevite@gmail.com>
@Kira-PilotKira-Pilot merged commit4b646cc intomainAug 17, 2022
@Kira-PilotKira-Pilot deleted the hide-agent-status/kira-pilot branchAugust 17, 2022 18:37
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jsjoeiojsjoeiojsjoeio left review comments

@kylecarbskylecarbskylecarbs approved these changes

@bpmctbpmctAwaiting requested review from bpmct

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI shows agent "connecting" when workspace is stopped
3 participants
@Kira-Pilot@jsjoeio@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp