- Notifications
You must be signed in to change notification settings - Fork928
add metadata to example templates#3451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code LGTM!
PS: Just be careful with the commit message. It is missing the prefix likechore: My message
examples/templates/aws-linux/main.tf Outdated
| } | ||
| item { | ||
| key = "disk" | ||
| value = "${aws_instance.dev.root_block_device[0].volume_size} GB" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nitpick: I think all of these "volume size" parameters are actually measured in GiB, not decimal GB. How about labeling them that way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
for sure!
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
resolves#3432
I manually tested each template