Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: handle workspace errors#3341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AbhineetJain merged 13 commits intomainfromabhineetjain/workspace-errors
Aug 5, 2022
Merged

Conversation

AbhineetJain
Copy link
Contributor

@AbhineetJainAbhineetJain commentedAug 1, 2022•
edited
Loading

This PR handles the errors shown on the Workspace (singular) page. We handle the following types of errors:

  • get workspace
  • check permissions
  • get resources
  • get builds
  • build error
  • build cancellation

Subtasks

  • display the errors using theErrorSummary component for the listed errors
  • add stories

Fixes#3094

Screenshots

get resources

Screen Shot 2022-08-01 at 1 35 54 PM

get builds

Screen Shot 2022-08-01 at 1 35 42 PM

build cancellation

Screen Shot 2022-08-01 at 1 35 30 PM

build error

Screen Shot 2022-08-01 at 1 18 15 PM

get workspace

Screen Shot 2022-08-01 at 1 36 51 PM

@AbhineetJainAbhineetJain requested a review froma team as acode ownerAugust 1, 2022 16:33
Copy link
Contributor

@presleyppresleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The code looks great! Do you know why the Chromatic check is being skipped?

@AbhineetJain
Copy link
ContributorAuthor

The code looks great! Do you know why the Chromatic check is being skipped?

@presleyp No idea, maybe the latest refactor in this PR (#3330) did it.

@AbhineetJain
Copy link
ContributorAuthor

@presleyp
Copy link
Contributor

Storybook makes it look like we're displaying an error message when a build is successfully canceled - is it supposed to be an error saying it failed to cancel? Or a success message about cancellation?

@AbhineetJainAbhineetJain merged commite7bc013 intomainAug 5, 2022
@AbhineetJainAbhineetJain deleted the abhineetjain/workspace-errors branchAugust 5, 2022 15:38
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@presleyppresleyppresleyp approved these changes

@kylecarbskylecarbskylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix error messages in workspaceXService
3 participants
@AbhineetJain@presleyp@kylecarbs
[8]ページ先頭
©2009-2025 Movatter.jp