Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Renametemplate update totemplate push#3307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ammario merged 2 commits intomainfromtemplate-push
Jul 29, 2022
Merged

Renametemplate update totemplate push#3307

ammario merged 2 commits intomainfromtemplate-push
Jul 29, 2022

Conversation

ammario
Copy link
Member

Before, there was atemplate edit AND atemplate update. The
distinction between both commands was easy to forget.push more
clearly indicates that the template's source code is being updated.

It is also complimentary to existingtemplate pull.

Before, there was a `template edit` AND a `template update`. Thedistinction between both commands was easy to forget. `push` moreclearly indicates that the template's source code is being updated.It is also complimentary to existing `template pull`.
@ammarioammario requested a review frompresleypJuly 29, 2022 19:06
Copy link
Contributor

@presleyppresleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Makes sense to me!

ammario reacted with thumbs up emoji
@ammarioammarioenabled auto-merge (squash)July 29, 2022 19:17
@ammarioammario merged commit6e63487 intomainJul 29, 2022
@ammarioammario deleted the template-push branchJuly 29, 2022 19:21
@sreya
Copy link
Collaborator

sreya commentedAug 1, 2022•
edited
Loading

@ammario what are you thoughts on setting an alias ofupdate ontemplates push? If anyone is using the CLI in CI this is almost guaranteed to break them when they update.

@ammario
Copy link
MemberAuthor

@sreya since this software is marked as alpha with no compat guarantees I would rather avoid the bloat right now.

@ammario
Copy link
MemberAuthor

When people start complaining about us breaking things we can reconsider... but let's keep the "move fast and break things" going for now.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@presleyppresleyppresleyp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ammario@sreya@presleyp
[8]ページ先頭
©2009-2025 Movatter.jp