- Notifications
You must be signed in to change notification settings - Fork928
fix: handlegetUser error#3285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd like to see the 500 error changed, but other than that, backend looks good. 👍🏻
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| export const LoginPage: React.FC = () => { | ||
| const styles = useStyles() | ||
| const location = useLocation() | ||
| const xServices = useContext(XServiceContext) | ||
| const [authState, authSend] = useActor(xServices.authXService) | ||
| const isLoading = authState.hasTag("loading") | ||
| const redirectTo = retrieveRedirect(location.search) | ||
| const locationState = location.state ? (location.state as LocationState) : null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do we need to use a ternary because of types? Or can we:
| constlocationState=location.state ?(location.stateasLocationState) :null | |
| constlocationState=location.state??null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
location.state can benull, but since we are typecasting it, the compiler thinks it is nevernull, so we are typecasting it only if it is not null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FE looks great!
| if (authState.matches("signedOut")) { | ||
| return <Navigate to={navigateTo} /> | ||
| return <Navigate to={navigateTo}state={{ isRedirect: !isHomePage }}/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
doesisRedirect replicate the functionality ofembedRedirect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think wecould use one both to know whether to show the error and where to go next, but it might be better to keep them separate like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, we’d probably have to retrieve the redirect in the component but that didn’t seem like a very solid approach.
Uh oh!
There was an error while loading.Please reload this page.
Building on#3241, this PR handles the
getUsererror fromauthXService.Special criteria: The error is only shown when redirecting to the
/loginpage from a page other than/. It is also not shown when loading the/loginpage directly.Subtasks
getUsererror above the Sign-in form/)You are signed out.orAn internal error occurredmessage and move the details in the error details section.Fixes#3088
Screenshot