- Notifications
You must be signed in to change notification settings - Fork928
Fix: surface error when over-extending workspace#3275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#3097
We were displaying a hard-coded error, and I changed it to display the error
messagefrom the backend. That message is currently not great in terms of specificity, but will improve with work@johnstcn is planning. It does not have adetailaspect, so there is no need to expand/collapse, and so I thought keeping the snackbar made sense.Testing
When I click + on the Workspace Schedule button too many times,
Then I see an error snackbar that says "Bad extend workspace request"
Once the backend error is updated, the snackbar will say something like "New deadline is greater than workspace allows"
With future work, the + button will be disabled so that it's impossible to elicit this error. It's just here in case of frontend bugs.