Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: switch from memfs to fstest.MapFS#327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jawnsy merged 2 commits intomainfromjawnsy/chore-memfs-to-fstest
Feb 18, 2022

Conversation

jawnsy
Copy link

@jawnsyjawnsy commentedFeb 18, 2022•
edited
Loading

  • Switch from memfs to built-in fstest.MapFS
  • Ensure httptest servers are closed during test cleanup
  • Swap ordering of expected/actual values in assertion functions
  • Use http.StatusOK constants for status codes
  • Add a 1-second context timeout for each request
  • Use the test httptest.Server.Client() so that we can handle
    TLS server certificates if desired

* Switch from memfs to built-in fstest.MapFS* Ensure httptest servers are closed during test cleanup* Swap ordering of expected/actual values in assertion functions* Use http.StatusOK constants for status codes* Add a 1-second context timeout for each request* Use the test httptest.Server.Client() so that we can handle  TLS server certificates if desired
@jawnsyjawnsyforce-pushed thejawnsy/chore-memfs-to-fstest branch frombb3a94d to3545416CompareFebruary 18, 2022 20:21
@jawnsyjawnsy self-assigned thisFeb 18, 2022
@jawnsyjawnsy marked this pull request as ready for reviewFebruary 18, 2022 20:22
@codecov
Copy link

codecovbot commentedFeb 18, 2022•
edited
Loading

Codecov Report

Merging#327 (ec71732) intomain (37bcfeb) willincrease coverage by3.87%.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff             @@##             main     #327      +/-   ##==========================================+ Coverage   63.61%   67.49%   +3.87%==========================================  Files          69      140      +71       Lines         786     7407    +6621       Branches       77       77              ==========================================+ Hits          500     4999    +4499- Misses        271     1897    +1626- Partials       15      511     +496
FlagCoverage Δ
unittest-go-macos-latest66.09% <ø> (?)
unittest-go-ubuntu-latest67.37% <ø> (?)
unittest-go-windows-latest65.69% <ø> (?)
unittest-js63.61% <ø> (ø)
Impacted FilesCoverage Δ
pty/start_other.go66.66% <0.00%> (ø)
httpmw/workspaceparam.go76.47% <0.00%> (ø)
coderd/projectversion.go55.22% <0.00%> (ø)
provisioner/terraform/parse.go77.77% <0.00%> (ø)
coderd/users.go58.76% <0.00%> (ø)
codersdk/client.go58.46% <0.00%> (ø)
codersdk/workspaces.go64.03% <0.00%> (ø)
peer/channel.go82.45% <0.00%> (ø)
provisioner/terraform/provision.go71.62% <0.00%> (ø)
httpmw/organizationparam.go69.81% <0.00%> (ø)
... and61 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update37bcfeb...ec71732. Read thecomment docs.

Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice! Another dependency bites the dust!

@jawnsyjawnsy merged commit5ef59e7 intomainFeb 18, 2022
@jawnsyjawnsy deleted the jawnsy/chore-memfs-to-fstest branchFebruary 18, 2022 21:03
@jawnsyjawnsy removed their assignmentMar 12, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kylecarbskylecarbskylecarbs approved these changes

@bryphe-coderbryphe-coderAwaiting requested review from bryphe-coder

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jawnsy@kylecarbs
[8]ページ先頭
©2009-2025 Movatter.jp