- Notifications
You must be signed in to change notification settings - Fork928
refactor: Initial color palette changes#3087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@hkfoster I see the colors are in |
| @@ -48,5 +48,6 @@ const useStyles = makeStyles((theme) => ({ | |||
| }, | |||
| avatar: { | |||
| marginRight: theme.spacing(1.5), | |||
| background: "hsl(219, 8%, 52%)", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do you think we could have it as apalette object liketheme.palette.paper.dark? Or something like that?
@hkfoster I also see some colors being used directly into the components, ideally IMO, they should be a color in the |
The new colors look nice tho, great job! |
Did you use the colors from here? |
😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 😍 |
I left a comment in the snapshots associated with this view, but looks like we lost the darkened box around our code snippet:
|
Just a thought: should we be using a darkened error color? This looks a little bright to me, but maybe it's better that way. |
@Kira-Pilot about the Dialog, I think we could keep it as it is for now, and about the dark color in the code example, I will fix that. |
cc.@Kira-Pilot |
I'mvery excited for this 😍 |
I forgot to update the copy button color: |
Uh oh!
There was an error while loading.Please reload this page.