Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Addcontinue-on-error to codecov action step#3081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 2 commits intomainfrommafredri/bypass-codecov-fail-check
Jul 20, 2022

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedJul 20, 2022
edited
Loading

Hopefully works around:codecov/codecov-action#788

Might bypass the failure, and makes sense not to trust the action with managing failure if we want to ignore it anyway.

@mafredrimafredri self-assigned thisJul 20, 2022
@mafredrimafredri requested a review froma teamJuly 20, 2022 18:43
@dwahler
Copy link
Contributor

Might want to also remove thefail_ci_if_error parameter, so that the codecov step itself returns an error status and is visibly marked as failing, even if it doesn't cause the rest of the job to fail.

@mafredri
Copy link
MemberAuthor

@dwahler It defaults tofalse, so we'd need to set it totrue, actually. Also, issue seems to be resolved now (at least for ubuntu and macos runners so-far), but I don't think merging this would be a bad idea even then, thoughts?

dwahler reacted with thumbs up emoji

@mafredri
Copy link
MemberAuthor

@dwahler actually, I'm not brave enough to setfail_ci_if_error: true since I don't know by what mechanism it's going to fail the action. As-such, I just cleaned it up a bit and added a comment explaining it.

dwahler reacted with thumbs up emoji

@mafredrimafredrienabled auto-merge (squash)July 20, 2022 19:04
@mafredrimafredri merged commit96edc8a intomainJul 20, 2022
@mafredrimafredri deleted the mafredri/bypass-codecov-fail-check branchJuly 20, 2022 19:04
demisgomes added a commit to demisgomes/itimalia that referenced this pull requestJul 20, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dwahlerdwahlerdwahler approved these changes

@kylecarbskylecarbskylecarbs approved these changes

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mafredri@dwahler@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp