- Notifications
You must be signed in to change notification settings - Fork928
fix: Statuses breaking line in the UI#3071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -79,7 +79,9 @@ export const BuildsTable: FC<BuildsTableProps> = ({ builds, className }) => { | ||
</span> | ||
</TableCellLink> | ||
<TableCellLink to={buildPageLink}> | ||
<span style={{ color: status.color }} className={styles.status}> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Now that this has a class, we can move the inline style into that class. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. It is inline because it is dynamic and passed from the props. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. we can still pass it i think, but nbd if you want to leave it inline! | ||
{status.status} | ||
</span> | ||
</TableCellLink> | ||
<TableCellLink to={buildPageLink}> | ||
<div className={styles.arrowCell}> | ||
@@ -126,4 +128,7 @@ const useStyles = makeStyles((theme) => ({ | ||
arrowCell: { | ||
display: "flex", | ||
}, | ||
status: { | ||
whiteSpace: "nowrap", | ||
}, | ||
})) |