- Notifications
You must be signed in to change notification settings - Fork928
fix: Statuses breaking line in the UI#3071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Going to check out the storybook when ready, but based on images shared in Discord this looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code changes look good 👍🏼
request: include screenshots for UI changes so that I don't have to pull locally or search through Chromatic
| @@ -79,7 +79,9 @@ export const BuildsTable: FC<BuildsTableProps> = ({ builds, className }) => { | |||
| </span> | |||
| </TableCellLink> | |||
| <TableCellLink to={buildPageLink}> | |||
| <span style={{ color: status.color }}>{status.status}</span> | |||
| <span style={{ color: status.color }} className={styles.status}> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Now that this has a class, we can move the inline style into that class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is inline because it is dynamic and passed from the props.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we can still pass it i think, but nbd if you want to leave it inline!
@kylecarbs these changes are not related to the Discord ones. It only avoids the status icon and the "verb" getting split into two lines on small viewports. |
@jsjoeio totally, since it was just a tiny small thing I skipped, but I will do it next time, my bad. |
@BrunoQuaresma ahh my bad, I just assumed 🙈 |
Closes#1982