- Notifications
You must be signed in to change notification settings - Fork1k
fix: Redirect to '?redirect' query parameter after successful login#307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecovbot commentedFeb 16, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #307 +/- ##==========================================+ Coverage 67.95% 68.02% +0.07%========================================== Files 135 135 Lines 7149 7156 +7 Branches 73 74 +1 ==========================================+ Hits 4858 4868 +10+ Misses 1804 1800 -4- Partials 487 488 +1
Continue to review full report at Codecov.
|
kylecarbs approved these changesFeb 17, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#304
Unblocks#298
After logging in, the login flow should redirect to a whatever path is specified by the
?redirect
query parameter. This is important for cases like#298 - where we need to set?redirect=%2Fcli_auth
, but also really any case where the user is linked and might have to go back to the login screen.The fix is simple - just check if the
redirect
query parameter is set, and if it is, use that as the path to redirect to on success. Also adds a test case - we had one checking that we redirect to the default (root/
) url, but not one of the?redirect
param