Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Proof of concept for licensing#3008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
presleyp wants to merge7 commits intomainfromlicensing-poc/presleyp/2904

Conversation

presleyp
Copy link
Contributor

@presleyppresleyp commentedJul 15, 2022
edited
Loading

Closes#2904
Things aren't named quite right yet but here's a start! I plan to add to this but wanted to share early.

requirements as I understand them:

  • license data must be fetched on app mount (which means also on browser refresh)
  • license data must be fetched any action that could cause compliance (user suspension, upgrading, disabling a feature) or change what's enabled
  • whenever warnings are present in the license data, the LicenseBanner must be shown on all pages containing all warnings
  • all features that areenabled in the license data must be available (soft enforcement)
  • all paid features must be unavailable to OSS users - I have kind of handled this by defaulting license data toenabled: false, but we should decide how the API will handle this case
  • there will be an admin page containing toggles for enabling/disabling all paid features. This page will be available to all non-OSS admins. Defaults will not handle this case so we should sync on a way for the frontend to know if they should get this page.
  • the toggle for any paid feature for whichentitled isfalse will show a warning, but the admin will be able to enable the feature (soft enforcement)

Solution:

  • licenseXService fetches license data on app mount, refresh, and various events and holds license data in global state
  • LicenseBanner displays any warnings
  • LicenseRequired page wrapper redirects OSS users to another page (currently 404, will later be something more informative) if they try to access a page that is entirely a paid feature
  • pages select visibility booleans fromlicenseXService to determine whether to show smaller features (coming next)

@presleyp
Copy link
ContributorAuthor

Closing because this has served its purpose.

@github-actionsgithub-actionsbot deleted the licensing-poc/presleyp/2904 branchFebruary 4, 2023 20:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@spikecurtisspikecurtisAwaiting requested review from spikecurtis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proof of concept for frontend licensing
1 participant
@presleyp

[8]ページ先頭

©2009-2025 Movatter.jp