- Notifications
You must be signed in to change notification settings - Fork928
fix: remove access column header#2976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Interestingly, Storybook isn't picking up the right alignment changes. 🤔 |
@AbhineetJain one small thing, can you make the |
| @@ -184,5 +183,6 @@ const useStyles = makeStyles((theme) => ({ | |||
| display: "flex", | |||
| gap: theme.spacing(0.5), | |||
| flexWrap: "wrap", | |||
| justifyContent: "right", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think you should useflex-end. I think "right" is not well supported. This should be the reason for Chromatic getting different styles.
| @@ -80,7 +79,7 @@ export const Resources: FC<ResourcesProps> = ({ | |||
| if (!agent) { | |||
| return ( | |||
| <TableRow key={`${resource.id}-${agentIndex}`}> | |||
| <TableCell className={styles.resourceNameCell}> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you check if we are using this anywhere else? If not, I think we should remove theresourceNameCell from themakeStyles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We're using it to show the border when agents exist. Removed it from the case when no agents exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, just minor stuff before the merge.
This PR removes the Access column header on the workspace page and aligns the access buttons to the right of the table row.
Additionally, we also remove the table column border when the resource does not have an agent.
Subtasks
Screenshot
Fixes#2974