Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: show last build initiator for workspaces#2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AbhineetJain merged 3 commits intomainfromabhineetjain/2865-initiator-ws-pages
Jul 12, 2022

Conversation

AbhineetJain
Copy link
Contributor

@AbhineetJainAbhineetJain commentedJul 12, 2022
edited
Loading

This PR shows the initiator of the last build on the workspace and workspaces pages.

Subtasks

  • added last build initiator on workspace page
  • added last build initiator on workspaces page
  • added missing unit tests for the util method

Fixes#2865

Screenshots

Workspace page

Screen Shot 2022-07-11 at 6 28 15 PM

Workspaces page

Screen Shot 2022-07-11 at 6 30 04 PM

@AbhineetJainAbhineetJain requested a review froma team as acode ownerJuly 12, 2022 01:10
Copy link
Member

@Kira-PilotKira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nice!

@@ -27,6 +28,7 @@ export const WorkspaceStats: FC<WorkspaceStatsProps> = ({ workspace }) => {
const styles = useStyles()
const theme = useTheme()
const status = getDisplayStatus(theme, workspace.latest_build)
const initiatedBy = getDisplayWorkspaceBuildInitiatedBy(theme, workspace.latest_build)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is this function unit tested?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice catch. Adding them now!

Kira-Pilot reacted with hooray emoji
@AbhineetJainAbhineetJain merged commitb0bab3e intomainJul 12, 2022
@AbhineetJainAbhineetJain deleted the abhineetjain/2865-initiator-ws-pages branchJuly 12, 2022 17:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show build initiator on workspaces (plural) and workspace (singular) pages
2 participants
@AbhineetJain@Kira-Pilot

[8]ページ先頭

©2009-2025 Movatter.jp