- Notifications
You must be signed in to change notification settings - Fork928
fix: removing noisy shutdown snapshots#2899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I noticed this too. Thanks for removing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Cleaner CI! 🙌 Is the plan to add the other non-visual tests in a separate PR?
@AbhineetJain we should! Right now, I'm trying to get some PRs unblocked, so I'vecreated a ticket to add those component tests. |
Uh oh!
There was an error while loading.Please reload this page.
resolves#2685
I'm just taking these snapshots out for now. They are causing noise on every PR and the
chromatic-ignoreattribute isn't solving our issue. In addition, I'm not sure these were good candidates for stories - I would argue these tests aren't visual.