- Notifications
You must be signed in to change notification settings - Fork1k
chore: bump github.com/quasilyte/go-ruleguard/dsl from 0.3.16 to 0.3.17#280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
chore: bump github.com/quasilyte/go-ruleguard/dsl from 0.3.16 to 0.3.17#280
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@dependabot rebase |
Bumps [github.com/quasilyte/go-ruleguard/dsl](https://github.com/quasilyte/go-ruleguard) from 0.3.16 to 0.3.17.- [Release notes](https://github.com/quasilyte/go-ruleguard/releases)- [Commits](quasilyte/go-ruleguard@dsl/v0.3.16...dsl/v0.3.17)---updated-dependencies:- dependency-name: github.com/quasilyte/go-ruleguard/dsl dependency-type: direct:production update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>
42b98c4 toc075ff1Comparecodecovbot commentedFeb 14, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #280 +/- ##==========================================+ Coverage 68.23% 68.32% +0.08%========================================== Files 126 126 Lines 6898 6898 Branches 69 69 ==========================================+ Hits 4707 4713 +6+ Misses 1713 1708 -5+ Partials 478 477 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Affects our custom go lint rules, looks like they all pass after this patch version bump - approved
jawnsy commentedFeb 14, 2022
be careful that this version matches the version shipped with go-critic (golangci-lint includes gocritic, gocritic includes the ruleguard dsl) -- the versions have to match, otherwise you can get unusual behavior where something works running ruleguard directly but does not work when running gocritic golangci-lint 1.44 includes go-critic 0.6.2https://github.com/golangci/golangci-lint/blob/617470fa9e2c54dd91ab91c14e0d20030e183c20/go.mod#L27 go-critic 0.6.2 includes go-ruleguard/dsl v0.3.12https://github.com/go-critic/go-critic/blob/f0a10a00c4ff012f328442fdd27426ca12ed03df/go.mod#L16-L17 the latest version of go-ruleguard/dsl is 0.3.17 |
Uh oh!
There was an error while loading.Please reload this page.
Bumpsgithub.com/quasilyte/go-ruleguard/dsl from 0.3.16 to 0.3.17.
Commits
a307c89dsl: add experimental Do() action2e73e37all: allow calling quasigo functions from quasigo (#378)dbd4b2cruleguard/quasigo: pass args via ValueStack (#377)6aa060fruletuard: change group filter signature (#376)cb19258ruleguard: implement Var.Object.IsGlobal() predicate (#370)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)