- Notifications
You must be signed in to change notification settings - Fork928
fix pubsub/poll race on provisioner job logs#2783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I like this EOF type thing 👍
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice fix!
Signed-off-by: spikecurtis <spike@spikecurtis.com>
// provisionerJobLogsMessage is the message type published on the provisionerJobLogsChannel() channel | ||
type provisionerJobLogsMessage struct { | ||
EndOfLogs bool `json:"end_of_logs,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This can beEnd
instead for naming redundancy.Final
may be more apt, chefs choice.
* fix pubsub/poll race on provisioner job logsSigned-off-by: Spike Curtis <spike@coder.com>* only cancel on non-errorSigned-off-by: Spike Curtis <spike@coder.com>* Improve logging & commentsSigned-off-by: spikecurtis <spike@spikecurtis.com>
Fixes#2603