Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix pubsub/poll race on provisioner job logs#2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 3 commits intomainfromspike/provisioner_job_logs_stream
Jul 1, 2022

Conversation

spikecurtis
Copy link
Contributor

Fixes#2603

Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtisspikecurtis requested a review froma teamJuly 1, 2022 18:26
Signed-off-by: Spike Curtis <spike@coder.com>
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I like this EOF type thing 👍

Copy link
Contributor

@dwahlerdwahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice fix!

Signed-off-by: spikecurtis <spike@spikecurtis.com>
@spikecurtisspikecurtis merged commitb1e4cfe intomainJul 1, 2022
@spikecurtisspikecurtis deleted the spike/provisioner_job_logs_stream branchJuly 1, 2022 21:07

// provisionerJobLogsMessage is the message type published on the provisionerJobLogsChannel() channel
type provisionerJobLogsMessage struct {
EndOfLogs bool `json:"end_of_logs,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This can beEnd instead for naming redundancy.Final may be more apt, chefs choice.

ketang pushed a commit that referenced this pull requestJul 3, 2022
* fix pubsub/poll race on provisioner job logsSigned-off-by: Spike Curtis <spike@coder.com>* only cancel on non-errorSigned-off-by: Spike Curtis <spike@coder.com>* Improve logging & commentsSigned-off-by: spikecurtis <spike@spikecurtis.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dwahlerdwahlerdwahler approved these changes

@kylecarbskylecarbskylecarbs left review comments

@EmyrkEmyrkEmyrk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

streaming job logs race condition means not all logs are returned / TestDelete flake
4 participants
@spikecurtis@dwahler@Emyrk@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp