- Notifications
You must be signed in to change notification settings - Fork928
feat: Add filter on Users page#2653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
db1ab2e tob94dba8Compare81dc68b to63e35c2ComparePumped on this |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| ])(`query=%p, filter=%p`,(query,filter)=>{ | ||
| expect(queryToFilter(query)).toEqual(filter) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
❤️
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Kira raises great questions but don't consider me a blocker on this. Excited to have this feature!
63e35c2 to4717f84Compare1031696 tobfbf729Compare| users: [], | ||
| roles: MockSiteRoles, | ||
| isLoading: true, | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I like this story since it tests a particular behavior of the component, but I am not sure if it is a good UI snapshot since the loader is spinning and the snapshot may change across different builds. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good thought. I haven't read through this in detail, but could we pause the animation for the loader? Or introduce a slight delay?https://www.chromatic.com/docs/animations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for pointing to this, I used
Loading.parameters={chromatic:{pauseAnimationAtEnd:true},}
and it seems to be constant for at least 3 builds.
| canEditUsers, | ||
| isLoading, | ||
| }) => { | ||
| const styles = useStyles() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this is so much clearer!!!!!!!!!!!! thank you!!!
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this is so well done!
Merging this now. If there are more concerns, we can handle them in a separate PR! 🎉 |
Uh oh!
There was an error while loading.Please reload this page.
This PR adds a new filter to the Users page.
Subtasks
Fixes#595
Screenshots