Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Remove 'Create Project' button, replace with CLI prompt#245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bryphe-coder merged 4 commits intomainfrombryphe/fix/project-create-cli
Feb 11, 2022

Conversation

bryphe-coder
Copy link
Contributor

For black-triangle and alpha builds, we won't be able to create projects in the UI, because they require collecting and tar'ing a set of assets associated with the project - so the CLI is going to be our entry point for creating projects.

This shifts the UI to remove the 'Create Project' button, and adds a prompt to copy a command to run.

Before:
image

After:
2022-02-10 19 38 01

Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Neato

bryphe-coder reacted with heart emoji
@codecov
Copy link

codecovbot commentedFeb 11, 2022
edited
Loading

Codecov Report

Merging#245 (5f683ea) intomain (a82fb8f) willdecrease coverage by0.08%.
The diff coverage is62.50%.

Impacted file tree graph

@@            Coverage Diff             @@##             main     #245      +/-   ##==========================================- Coverage   67.31%   67.23%   -0.09%==========================================  Files         120      124       +4       Lines        6484     6516      +32       Branches       67       69       +2     ==========================================+ Hits         4365     4381      +16- Misses       1701     1714      +13- Partials      418      421       +3
FlagCoverage Δ
unittest-go-macos-latest65.13% <ø> (-0.23%)⬇️
unittest-go-ubuntu-latest66.43% <ø> (-0.12%)⬇️
unittest-go-windows-latest66.28% <ø> (+0.13%)⬆️
unittest-js65.24% <62.50%> (+0.48%)⬆️
Impacted FilesCoverage Δ
site/components/CodeExample/index.ts0.00% <0.00%> (ø)
site/pages/projects/index.tsx0.00% <0.00%> (ø)
site/theme/palettes.ts100.00% <ø> (ø)
site/components/Button/CopyButton.tsx52.38% <52.38%> (ø)
site/components/Button/index.ts100.00% <100.00%> (ø)
site/components/CodeBlock/index.tsx100.00% <100.00%> (ø)
site/components/CodeExample/CodeExample.tsx100.00% <100.00%> (ø)
site/components/Icons/FileCopy.tsx100.00% <100.00%> (ø)
site/components/Icons/index.ts100.00% <100.00%> (ø)
peer/conn.go80.25% <0.00%> (-1.29%)⬇️
... and2 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatea82fb8f...5f683ea. Read thecomment docs.

@bryphe-coderbryphe-coder merged commitdf13fef intomainFeb 11, 2022
@bryphe-coderbryphe-coder deleted the bryphe/fix/project-create-cli branchFebruary 11, 2022 05:37
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kylecarbskylecarbskylecarbs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bryphe-coder@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp