Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Show build initiator on Workspace Build page#2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AbhineetJain merged 2 commits intomainfromabhineetjain/2029-show-build-reason
Jun 20, 2022

Conversation

AbhineetJain
Copy link
Contributor

@AbhineetJainAbhineetJain commentedJun 16, 2022•
edited
Loading

This PR builds on#2438 and shows the workspace build initiator on the Workspace Build page.

Subtasks

  • add a column in the stats to show build initiator
  • format the initiator based on reason
  • add stories

Fixes#2029
Fixes#2410

Screenshots

Screen Shot 2022-06-16 at 7 27 50 PM

Screen Shot 2022-06-16 at 7 20 28 PM

Screen Shot 2022-06-16 at 7 20 49 PM

@AbhineetJainAbhineetJain requested a review froma team as acode ownerJune 16, 2022 23:21
@AbhineetJain
Copy link
ContributorAuthor

Also looking for design comments on the highlighting.

@AbhineetJainAbhineetJainforce-pushed theabhineetjain/2029-show-build-reason-in-ui branch 2 times, most recently from4802eaf toc5b9aacCompareJune 17, 2022 16:21
return {
color: theme.palette.secondary.dark,
initiatedBy: DisplayWorkspaceBuildInitiatedByLanguage.autostop,
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

My feeling (and I know this is boring of me) is that we probably don't need to highlight these values in purple. I am concerned we will be drawing too much attention to information that, while important, is not particularly actionable. That being said, I love that you tried a different design! Maybe post this in the dev-ux channel to get more opinions - I'm not a designer by any stretch of the imagination haha.

AbhineetJain reacted with thumbs up emoji
@Kira-Pilot
Copy link
Member

nice job! I wonder if we want to move the new column by thestarted at column (and maybe call it 'started by'??) for parity.

Base automatically changed fromabhineetjain/2029-show-build-reason-in-ui tomainJune 17, 2022 17:41
@AbhineetJainAbhineetJainforce-pushed theabhineetjain/2029-show-build-reason branch from77b539e toe51aba2CompareJune 17, 2022 17:48
@AbhineetJain
Copy link
ContributorAuthor

@Kira-Pilot Thanks for the suggestions. I am merging this for now. Let's create another issue to discuss the design, and if we reach a consensus, we can update it.

Kira-Pilot reacted with thumbs up emoji

@AbhineetJainAbhineetJain merged commit8a853a6 intomainJun 20, 2022
@AbhineetJainAbhineetJain deleted the abhineetjain/2029-show-build-reason branchJune 20, 2022 14:38
@ketang
Copy link
Contributor

@AbhineetJain I'm not seeing this on dev.coder.com. I'm looking at both the workspaces (plural) and workspace (singular) pages.

@AbhineetJain
Copy link
ContributorAuthor

@ketang The initiator is shown for each build of the workspace. You may check any of the workspace builds from the timeline table.

@ketang
Copy link
Contributor

Aaah okay I see now. The description says "Workspace Build" page, but I was looking at the Workspace page. I'll file an issue for that.

@ketang
Copy link
Contributor

ketang commentedJul 8, 2022•
edited
Loading

#2865

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show the reason for workspace action on build page Show Initiator in Build Logs
3 participants
@AbhineetJain@Kira-Pilot@ketang
[8]ページ先頭
©2009-2025 Movatter.jp