- Notifications
You must be signed in to change notification settings - Fork1k
fix: flaky install.sh upgrade on OSX (zsh killed)#2309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| Standalone release has been installed into$STANDALONE_INSTALL_PREFIX/bin/$STANDALONE_BINARY_NAME | ||
| Standalone release has been installed into$STANDALONE_INSTALL_PREFIX/bin/$STANDALONE_BINARY_NAME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
did a lil bit of formatting here
| # Remove the file if it already exists to | ||
| # avoid https://github.com/coder/coder/issues/2086 | ||
| if [-f"$COPY_LOCATION" ];then | ||
| "$sh_c" rm$COPY_LOCATION | ||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
mv would also work here instead of cp.
https://developer.apple.com/forums/thread/130313?answerId=410704022#410704022
misskniss left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That fixed it for me. Thanks@bpmct !
Uh oh!
There was an error while loading.Please reload this page.
Fixes#2086. This likely has something to do with how MacOS trusts binaries
To test
@misskniss @mark-theshark - would appreciate if you could confirm this fixes it
Broken:
Fixed: