Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: workspace schedule time displays#2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
greyscaled merged 4 commits intomainfromvapurrmaid/schedule-bug
Jun 10, 2022
Merged

Conversation

greyscaled
Copy link
Contributor

@greyscaledgreyscaled commentedJun 10, 2022
edited
Loading

Resolves:#2235

Summary:

Various time displays weren't quite right.

Details:

  • Display date (not just time) of upcoming workspace stop in workspace
    page
  • Fix ttlShutdownAt for various cases + tests
    --> manual to non-manual
    --> unchanged/unmodified
    --> isBefore --> isSameOrBefore
    --> use the delta (off by _ error)

Summary:Various time displays weren't quite right.Details:- Display date (not just time) of upcoming workspace stop in workspacepage- Fix ttlShutdownAt for various cases + tests--> manual to non-manual--> unchanged/unmodified--> isBefore --> isSameOrBefore--> use the delta (off by _ error)
@greyscaledgreyscaled requested a review froma team as acode ownerJune 10, 2022 16:36
@greyscaledgreyscaled self-assigned thisJun 10, 2022
@greyscaledgreyscaledenabled auto-merge (squash)June 10, 2022 17:20
@greyscaledgreyscaled merged commit928958c intomainJun 10, 2022
@greyscaledgreyscaled deleted the vapurrmaid/schedule-bug branchJune 10, 2022 17:26
Kira-Pilot added a commit that referenced this pull requestJun 14, 2022
* feat: update build url to @username/workspace/builds/buildnumber (#2234)* update build url to @username/workspace/builds/buildnumber* update errors thrown from the API* add unit tests for the new API* add t.parallel* get username and workspace name from params* fix: update icon (#2216)* feat: Show template description in `coder template init` (#2238)* fix: workspace schedule time displays (#2249)Summary:Various time displays weren't quite right.Details:- Display date (not just time) of upcoming workspace stop in workspacepage- Fix ttlShutdownAt for various cases + tests  - manual to non-manual  - unchanged/unmodified  - isBefore --> isSameOrBefore  - use the delta (off by _ error)- pluralize units in dayjs.add* fix: Remove easter egg mentioning competitor (#2250)This is more confusing than helpful!* feat: Warn on coderd startup if access URL is localhost (#2248)* feat: use custom wireguard reverse proxy for dev tunnel (#1975)* fix: use correct link in create from template button (#2253)* feat: store and display template creator (#2228)* design commit* add owner_id to templates table* add owner information in apis and ui* update minWidth for statItem* rename owner to created_by* missing refactor to created_by* handle errors in fetching created_by names* feat: update language on workspace page (#2220)* fix: ensure config dir exists before reading tunnel config (#2259)* fix(devtunnel): close `http.Server` before wireguard interface (#2263)* fix: ensure `agentResource` is non-nil (#2261)* chore: add hero image to OSS docs homepage (#2241)* fix: Do not write 2 errors to api on template fetch error (#2285)* feat: add tooltips to templates pageresolves#2242Co-authored-by: Abhineet Jain <AbhineetJain@users.noreply.github.com>Co-authored-by: Joe Previte <jjprevite@gmail.com>Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>Co-authored-by: G r e y <grey@coder.com>Co-authored-by: Kyle Carberry <kyle@coder.com>Co-authored-by: David Wahler <david@coder.com>Co-authored-by: Colin Adler <colin1adler@gmail.com>Co-authored-by: Garrett Delfosse <garrett@coder.com>Co-authored-by: Katie Horne <katie@coder.com>Co-authored-by: Steven Masley <Emyrk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees

@greyscaledgreyscaled

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shutdown section: if Time until shutdown is more than 24h displayed value is confusing
3 participants
@greyscaled@johnstcn@Kira-Pilot

[8]ページ先頭

©2009-2025 Movatter.jp