Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: update language on workspace page#2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Kira-Pilot merged 1 commit intomainfromadd-workspace-table-header/kira-pilot
Jun 10, 2022
Merged
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletionssite/src/components/WorkspaceStats/WorkspaceStats.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,10 +7,12 @@ import { Workspace } from "../../api/typesGenerated"
import { CardRadius, MONOSPACE_FONT_FAMILY } from "../../theme/constants"
import { combineClasses } from "../../util/combineClasses"
import { getDisplayStatus } from "../../util/workspace"
import { WorkspaceSection } from "../WorkspaceSection/WorkspaceSection"

const Language = {
workspaceDetails: "Workspace Details",
templateLabel: "Template",
statusLabel: "Status",
statusLabel: "WorkspaceStatus",
versionLabel: "Version",
lastBuiltLabel: "Last Built",
outdated: "Outdated",
Expand All@@ -27,7 +29,7 @@ export const WorkspaceStats: FC<WorkspaceStatsProps> = ({ workspace }) => {
const status = getDisplayStatus(theme, workspace.latest_build)

return (
<div className={styles.stats}>
<WorkspaceSection title={Language.workspaceDetails} contentsProps={{ className:styles.stats }}>
<div className={styles.statItem}>
<span className={styles.statsLabel}>{Language.templateLabel}</span>
<Link
Expand DownExpand Up@@ -65,7 +67,7 @@ export const WorkspaceStats: FC<WorkspaceStatsProps> = ({ workspace }) => {
</span>
</span>
</div>
</div>
</WorkspaceSection>
)
}

Expand All@@ -79,7 +81,7 @@ const useStyles = makeStyles((theme) => ({
alignItems: "center",
color: theme.palette.text.secondary,
fontFamily: MONOSPACE_FONT_FAMILY,
border: `1px solid ${theme.palette.divider}`,
margin: "0px",
Copy link
Contributor

@greyscaledgreyscaledJun 10, 2022
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'mpretty sure you can just pass the number0 likemargin: 0. No idea if that's preferred or not, just thought I'd mention it for knowledge-share/curiosity

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah, you're right. I always add them because I used to get NITed at an old job when I left them off. A brief google search doesn't reveal any strong opinions. I'm open to any convention!

greyscaled reacted with heart emoji
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yea I have no strong feelings either, I really don't know what's best hence curiosity.

I never want to unintentionally nit though, so I try to use conventional comments. I should've said

Thought(curiosity)

because code is like a beautiful article that creates interesting discussion, sometimes of which leads to edits, but often just leads to better understandings for future articles.

IDK.

It's friday.

Kira-Pilot reacted with heart emoji
},

statItem: {
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp